Skip to content

Commit ea60574

Browse files
Merge branch 'master' into fix-skip-before-filter
2 parents f8ee594 + 2b121c7 commit ea60574

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

lib/open_sesame/configuration.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ class Configuration
1010
:enabled,
1111
:debug,
1212
:full_host,
13+
:vetted_github_logins,
1314
:auto_access_provider,
1415
:after_login_path,
1516
:after_logout_path

lib/open_sesame/member.rb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,21 @@ def self.find(member_login)
2020
def self.find_member(member_login)
2121
members.detect { |m| m.login == member_login } || begin
2222
client.user(member_login)
23-
rescue Octokit::Error => ek
23+
rescue Octokit::Error => e
2424
OpenSesame.logger.info e
2525
end
2626
end
2727

2828
def self.member?(member_login)
29-
member_logins.include?(member_login) || begin
29+
member_logins.include?(member_login) ||
30+
vetted_github_login?(member_login) ||
3031
client.organization_member?(organization_name, member_login)
31-
rescue Octokit::ServerError => e
32-
OpenSesame.logger.info e
33-
end
32+
rescue Octokit::ServerError => e
33+
OpenSesame.logger.info e
34+
end
35+
36+
def self.vetted_github_login?(member_login)
37+
OpenSesame.vetted_github_logins.include?(member_login)
3438
end
3539

3640
# memoized list of accepted member

opensesame.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
1818

1919
s.add_dependency "rails", ">= 3.2"
2020
s.add_dependency "omniauth-github"
21-
s.add_dependency "octokit", "~> 2.3"
21+
s.add_dependency 'octokit', '~> 4.16'
2222
s.add_dependency "faraday-http-cache"
2323
s.add_dependency "warden"
2424

spec/dummy/config/initializers/opensesame.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@
1818
config.organization 'challengepost'
1919
config.mounted_at '/opensesame'
2020
config.github app_id, secret
21+
config.vetted_github_logins = []
2122
config.debug = true
2223
end

0 commit comments

Comments
 (0)