Skip to content

Bug fix: django full_clean does not work because of wrong exception is raised#106

Open
raducup wants to merge 2 commits into
rbarrois:masterfrom
raducup:master
Open

Bug fix: django full_clean does not work because of wrong exception is raised#106
raducup wants to merge 2 commits into
rbarrois:masterfrom
raducup:master

Conversation

@raducup

@raducup raducup commented Aug 31, 2020

Copy link
Copy Markdown

Django fields should raise ValidationError in case the value is incorrect, not ValueError.
https://docs.djangoproject.com/en/3.1/ref/forms/validation/

@raducup raducup changed the title fix-django-full_clean-error Bug fix: django full_clean does not work because of wrong exception is raised Oct 24, 2020
@raducup

raducup commented Dec 4, 2020

Copy link
Copy Markdown
Author

Hello @rbarrois, could you please approve this pool request?

@kennell

kennell commented Dec 8, 2020

Copy link
Copy Markdown

I woudl also appreciate if this gets merged please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants