isActive() on the useSelections api is not set to false when clearing selections in the toolbar

[haxxmaxx]

🐛 Bug report

When calling isActive() on the useSelections api after clearing selections in the toolbar, it returns true. This works if I run the same chart in sense.

Steps to Reproduce

1. Make selections in some chart
2. Clear using the toolbar
3. Call isActive -> returns true

Expected behavior

Should always return false when no active selections, as in sense.

Actual behavior

Returns true even though selections are cleared and canceled

Versions

• nebula.js: 1.1.0
• Platform: osx
• Browser: chrome

Additional context

Illustrated in the gif: When you press a cell, isActive is called. The first time when no selections are made, it returns false. The second time it is still true.

[Caele]

The useObjectSelections object can't currently listen to the modal state change so it can't set its internal isActive property. isModal is a better check but is currently unavailable in the client. We'll look at sorting this out, but in the meantime we can avoid relying on these specifically.

[T-Wizard]

@haxxmaxx does it work if you use isActive indirect.
by storing the value in a useState and update it on the 'activated' and 'deactivated' events

[haxxmaxx]

Haven't tried, worth a shot. I'll try it

[haxxmaxx]

Yup that works