(bug) Fix HelmReleaseSummary.FailureMessage never persisted after chart deployment failure

When a Helm chart deployment fails, setHelmFailureMessageOnHelmChartSummary correctly sets FailureMessage on
clusterSummary.Status.HelmReleaseSummaries[i] in memory, but this value was never written back to the API server.

The root cause is a sequencing issue: updateStatusForReferencedHelmReleases (which persists HelmReleaseSummaries)
runs before walkChartsAndDeploy. After walkChartsAndDeploy fails and sets the FailureMessage in memory,
updateStatusForNonReferencedHelmReleases then re-fetches a fresh ClusterSummary from the API and overwrites the status,
so discarding the in-memory change entirely.

As a result, HelmReleaseSummaries[].FailureMessage always remained empty even after repeated failures,
while featureSummaries[].failureMessage (set through a separate path) correctly reflected the error.

A secondary bug: setHelmFailureMessageOnHelmChartSummary was passed currentChart (the raw, pre-template spec) instead of
instantiatedChart. The lookup compares ReleaseName/ReleaseNamespace against values stored in HelmReleaseSummaries, which
are the instantiated values. When those fields contain Go templates, the lookup would silently find no match and the
FailureMessage would not be set at all.

Fix consist in:
1. Pass instantiatedChart (post-template) instead of currentChart to setHelmFailureMessageOnHelmChartSummary so the lookup
always matches what is stored in HelmReleaseSummaries.
2. In updateStatusForNonReferencedHelmReleases, before overwriting the status with the freshly fetched ClusterSummary, build
an index of the in-memory FailureMessage values set by walkChartsAndDeploy and merge them into the entries being written. This
ensures the failure from the current reconciliation round is persisted to the API.

Author: gianlucam76

controllers/handlers_helm.go

@@ -1009,7 +1009,7 @@ func walkChartsAndDeploy(ctx context.Context, c client.Client, clusterSummary *c
 		var currentRelease *releaseInfo
 		currentRelease, report, err = handleChart(ctx, clusterSummary, mgmtResources, instantiatedChart,
 			kubeconfig, isPullMode, logger)
-		setHelmFailureMessageOnHelmChartSummary(clusterSummary, currentChart, err)
+		setHelmFailureMessageOnHelmChartSummary(clusterSummary, instantiatedChart, err)
 		if err != nil {
 			if clusterSummary.Spec.ClusterProfileSpec.ContinueOnError {
 				errorMsg += fmt.Sprintf("chart: %s, release: %s, %v\n",
@@ -2729,11 +2729,23 @@ func updateStatusForNonReferencedHelmReleases(ctx context.Context, c client.Clie
 		return clusterSummary, err
 	}
 
+	// Index the in-memory FailureMessages written by walkChartsAndDeploy so they are
+	// not lost when we overwrite the status from the freshly fetched currentClusterSummary.
+	inMemoryFailure := make(map[string]*string, len(clusterSummary.Status.HelmReleaseSummaries))
+	for i := range clusterSummary.Status.HelmReleaseSummaries {
+		s := &clusterSummary.Status.HelmReleaseSummaries[i]
+		inMemoryFailure[helmInfo(s.ReleaseNamespace, s.ReleaseName)] = s.FailureMessage
+	}
+
 	helmReleaseSummaries := make([]configv1beta1.HelmChartSummary, 0, len(currentClusterSummary.Status.HelmReleaseSummaries))
 	for i := range currentClusterSummary.Status.HelmReleaseSummaries {
 		summary := &currentClusterSummary.Status.HelmReleaseSummaries[i]
 		if _, ok := currentlyReferenced[helmInfo(summary.ReleaseNamespace, summary.ReleaseName)]; ok {
-			helmReleaseSummaries = append(helmReleaseSummaries, *summary)
+			entry := *summary
+			if msg, exists := inMemoryFailure[helmInfo(summary.ReleaseNamespace, summary.ReleaseName)]; exists {
+				entry.FailureMessage = msg
+			}
+			helmReleaseSummaries = append(helmReleaseSummaries, entry)
 		}
 	}