Skip to content

Commit aa1eaf5

Browse files
[ISS-1258][DC] renaming the function to meet length requirements
1 parent bf38353 commit aa1eaf5

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

pre_commit_hooks/detect_aws_credentials.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def get_aws_secrets_from_env() -> set[str]:
3636
return keys
3737

3838

39-
def get_aws_secrets_from_json_file(json_credentials_file: str) -> set[str]:
39+
def get_aws_secrets_from_json(json_credentials_file: str) -> set[str]:
4040
"""Extract AWS secrets from JSON configuration files.
4141
4242
Read a JSON-style configuration file and return a set with all found AWS
@@ -141,7 +141,7 @@ def main(argv: Sequence[str] | None = None) -> int:
141141
action='append',
142142
default=['~/.aws/cli/cache/', '~/.aws/login/cache/'],
143143
help=(
144-
'Location of additional AWS JSON credential file from which to get '
144+
'Location of AWS JSON credential files from which to get '
145145
'secret keys. Can be passed multiple times.'
146146
),
147147
)
@@ -174,7 +174,7 @@ def main(argv: Sequence[str] | None = None) -> int:
174174
keys |= get_aws_secrets_from_file(credential_file)
175175

176176
for json_credential_file in json_credential_files:
177-
keys |= get_aws_secrets_from_json_file(json_credential_file)
177+
keys |= get_aws_secrets_from_json(json_credential_file)
178178
# Secrets might be part of environment variables, so add such secrets to
179179
# the set of keys.
180180
keys |= get_aws_secrets_from_env()

tests/detect_aws_credentials_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from pre_commit_hooks.detect_aws_credentials import get_aws_cred_files_from_env
88
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_env
99
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_file
10-
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_json_file
10+
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_json
1111
from pre_commit_hooks.detect_aws_credentials import main
1212
from testing.util import get_resource_path
1313

@@ -84,9 +84,9 @@ def test_get_aws_secrets_from_env(env_vars, values):
8484
('ok_json.json', set()),
8585
),
8686
)
87-
def test_get_aws_secrets_from_json_file(filename, expected_keys):
87+
def test_get_aws_secrets_from_json(filename, expected_keys):
8888
"""Test that reading secrets from files works."""
89-
keys = get_aws_secrets_from_json_file(get_resource_path(filename))
89+
keys = get_aws_secrets_from_json(get_resource_path(filename))
9090
assert keys == expected_keys
9191

9292

0 commit comments

Comments
 (0)