Problem description
The stream manager in python client has two flags to turn on the auth and tls, but it is not mentioned in the documentation or code comments, especially this line is misleading which makes a bad example for users.
|
/// manager=pravega_client.StreamManager("tls://127.0.0.1:9090") |
Problem location
stream_manager.rs
Suggestions for an improvement
Add some more documentation to explain these two flags, and in the documentation PythonBindings.md and tests pravega_reader_test.py, it would be better to use explicit flag settings.
Problem description
The stream manager in python client has two flags to turn on the auth and tls, but it is not mentioned in the documentation or code comments, especially this line is misleading which makes a bad example for users.
pravega-client-rust/python/src/stream_manager.rs
Line 38 in e4e1ae7
Problem location
stream_manager.rsSuggestions for an improvement
Add some more documentation to explain these two flags, and in the documentation
PythonBindings.mdand testspravega_reader_test.py, it would be better to use explicit flag settings.