AI feedback

Author: simolus3

packages/sqlite_async/CHANGELOG.md

@@ -5,6 +5,9 @@
 - __Breaking__: Rewrite the native connection pool implementation.
   - Remove isolate connection factories. Simply open the same database on another isolate, it's safe to do so now.
   - It is no longer possible to register user-defined functions in Dart. Extensions providing functions in native code can still be used.
+- __Breaking__: Remove `AbstractDefaultSqliteOpenFactory` and `DefaultSqliteOpenFactory`. Use `SqliteOpenFactory` instead.
+  To provide a custom open factory, import `NativeSqliteOpenFactory` or `WebSqliteOpenFactory` with a platform-specific
+  import and extend those classes.
 - __Breaking__: Remove the `maxReaders` parameter on `SqliteDatabase`. Set that parameter on `SqliteOptions` instead.
 - __Breaking__: Remove libraries exporting the `sqlite3` package:
   - Instead of `package:sqlite_async/sqlite3.dart`, import `package:sqlite3/sqlite3.dart`.

packages/sqlite_async/lib/src/common/sqlite_database.dart

@@ -62,8 +62,7 @@ abstract base class SqliteDatabase
   /// do not block read transactions, and read transactions will see the state
   /// from the last committed write transaction.
   factory SqliteDatabase(
-      {required String path,
-      SqliteOptions options = const SqliteOptions.defaults()}) {
+      {required String path, SqliteOptions options = const SqliteOptions()}) {
     return SqliteDatabase.withFactory(
       SqliteOpenFactory(path: path, options: options),
     );

packages/sqlite_async/lib/src/native/database/native_sqlite_database.dart

@@ -30,8 +30,7 @@ import 'worker.dart';
 final class NativeSqliteDatabaseImpl extends SqliteDatabaseImpl {
   @override
   final NativeSqliteOpenFactory openFactory;
-  late final Future<SqliteConnectionPool> _pool =
-      _openNativePool(openFactory, maxReaders);
+  late final Future<SqliteConnectionPool> _pool = _openNativePool(openFactory);
   bool _isClosed = false;
   final _lockGuard = Object();
 
@@ -290,11 +289,11 @@ final class NativeSqliteDatabaseImpl extends SqliteDatabaseImpl {
 
   static Future<SqliteConnectionPool> _openNativePool(
     NativeSqliteOpenFactory openFactory,
-    int maxReaders,
   ) {
     // We want to open pools asynchronously since running pragma statements as
     // part of openFactory.open might do IO. openAsync spawn a temporary isolate
     // for that.
+    final maxReaders = openFactory.sqliteOptions.maxReaders;
     return SqliteConnectionPool.openAsync(
       name: openFactory.path,
       openConnections: () {

packages/sqlite_async/lib/src/sqlite_options.dart

@@ -2,9 +2,8 @@ final class WebSqliteOptions {
   final String workerUri;
   final String wasmUri;
 
-  const WebSqliteOptions.defaults()
-      : workerUri = 'db_worker.js',
-        wasmUri = 'sqlite3.wasm';
+  @Deprecated('Use default WebSqliteOptions constructor instead')
+  const factory WebSqliteOptions.defaults() = WebSqliteOptions;
 
   const WebSqliteOptions(
       {this.wasmUri = 'sqlite3.wasm', this.workerUri = 'db_worker.js'});
@@ -51,7 +50,7 @@ final class SqliteOptions {
     this.journalMode = SqliteJournalMode.wal,
     this.journalSizeLimit = 6 * 1024 * 1024,
     this.synchronous = SqliteSynchronous.normal,
-    this.webSqliteOptions = const WebSqliteOptions.defaults(),
+    this.webSqliteOptions = const WebSqliteOptions(),
     this.lockTimeout = const Duration(seconds: 30),
     this.profileQueries = _profileQueriesByDefault,
     this.maxReaders = defaultMaxReaders,

packages/sqlite_async/lib/src/web/database.dart

@@ -8,29 +8,13 @@ import 'package:sqlite3_web/sqlite3_web.dart';
 import 'package:sqlite_async/sqlite_async.dart';
 import 'package:sqlite_async/src/utils/profiler.dart';
 import 'package:sqlite_async/src/web/database/broadcast_updates.dart';
-import 'package:web/web.dart';
 import '../common/sqlite_database.dart';
 import '../common/timeouts.dart';
 import '../impl/context.dart';
 import 'connection.dart';
 import 'protocol.dart';
 import 'web_mutex.dart';
 
-/// An endpoint that can be used, by any running JavaScript context in the same
-/// website, to connect to an existing [WebDatabase].
-///
-/// These endpoints are created by calling [WebDatabase.exposeEndpoint]
-/// and consist of a [MessagePort] and two [String]s internally identifying the
-/// connection. Both objects can be transferred over send ports towards another
-/// worker or context. That context can then use
-/// [WebDatabase.connectToEndpoint] to connect to the port already
-/// opened.
-typedef WebDatabaseEndpoint = ({
-  MessagePort connectPort,
-  String connectName,
-  String? lockName,
-});
-
 final class WebDatabase extends SqliteDatabaseImpl
     implements WebSqliteConnection {
   final Database _database;

packages/sqlite_async/lib/src/web/web_sqlite_open_factory.dart

@@ -32,8 +32,7 @@ base class WebSqliteOpenFactory extends InternalOpenFactory {
   });
 
   WebSqliteOpenFactory(
-      {required super.path,
-      super.sqliteOptions = const SqliteOptions.defaults()}) {
+      {required super.path, super.sqliteOptions = const SqliteOptions()}) {
     // Make sure initializer starts running immediately
     _initialized;
   }

packages/sqlite_async/test/utils/abstract_test_utils.dart

@@ -7,8 +7,7 @@ abstract class AbstractTestUtils {
   Future<CommonDatabase> openDatabaseForSingleConnection();
 
   Future<SqliteOpenFactory> testFactory(
-      {String? path,
-      SqliteOptions options = const SqliteOptions.defaults()}) async {
+      {String? path, SqliteOptions options = const SqliteOptions()}) async {
     return SqliteOpenFactory(path: path ?? dbPath(), options: options);
   }
 

packages/sqlite_async/test/utils/native_test_utils.dart

@@ -1,8 +1,8 @@
 import 'dart:async';
 import 'dart:io';
 
+import 'package:sqlite3/common.dart';
 import 'package:sqlite3/sqlite3.dart';
-import 'package:sqlite3/src/database.dart';
 import 'package:test_descriptor/test_descriptor.dart' as d;
 
 import 'abstract_test_utils.dart';

packages/sqlite_async/test/utils/stub_test_utils.dart

@@ -1,4 +1,4 @@
-import 'package:sqlite3/src/database.dart';
+import 'package:sqlite3/common.dart';
 
 import 'abstract_test_utils.dart';
 

packages/sqlite_async/test/utils/web_test_utils.dart

@@ -57,7 +57,7 @@ class TestUtils extends AbstractTestUtils {
   @override
   Future<SqliteOpenFactory> testFactory({
     String? path,
-    SqliteOptions options = const SqliteOptions.defaults(),
+    SqliteOptions options = const SqliteOptions(),
   }) async {
     await _isInitialized;
     return super.testFactory(