Meson issues

[tristan957]

All the root*dir logic is unnecessary. Subprojects inherit the standard directories from the root project. I don't really know why there is an iniparserdir option. Please remove it because if I have a prefix in the root project of /opt/cxl-reskit, then Meson fails looking for the iniparser headers in /opt/cxl-reskit/include because the prefix doesn't exist.

if get_option('systemd').enabled()
  systemd = dependency('systemd', required : true)
  systemdunitdir = systemd.get_pkgconfig_variable('systemdsystemunitdir')
  udev = dependency('udev', required : true)
  udevdir = udev.get_pkgconfig_variable('udevdir')
  udevrulesdir = udevdir / 'rules.d'
endif

You are effectively making -Dsystemd a boolean instead of a feature with this logic.

Please use meson.override_find_program() and meson.override_dependency() as necessary for an binaries and dependencies.

These are just a few issues that I have had trying to consume this build system.

[tristan957]

I can refer you to a Meson maintainer within Intel if help is needed.

[AlisonSchofield]

I looked at the reporters concerns and still seem valid:

• the root*dir logic is still there and may cause the exact problems the user describes if the paths don’t exist
• the iniparserdir issue has not been fully addressed. The option is still present, and the build can fail on custom prefixes.

These fix-ups are not strictly mandatory but its fragile and non-standard.