feat(SRE-8899): only support the new approach (migration 2/2)

Author: vmarlier

docker-compose.yml

@@ -8,7 +8,6 @@ services:
       - APPLICATION_NAME
     volumes:
       - env:$WORKDIR
-      - ./test/fixture/volumes/aws-secret:$WORKDIR/aws-secret
       - ./test/fixture/volumes/aws-secret-application:$WORKDIR/aws-secret-application
       - ./test/fixture/volumes/aws-parameter-store:$WORKDIR/aws-parameter-store
       - ./test/fixture/volumes/global-aws-secret:$WORKDIR/global-aws-secret

parse-config.sh

@@ -62,19 +62,21 @@ load_dir() {
   fi
 }
 
-# We have 3 directories to load env variables from:
+# We have 4 directories to load env variables from.
+#
+# 2 are shipped from application helm-chart and scoped to the application:
 #   1. $WORKDIR/aws-parameter-store
-#   2. $WORKDIR/aws-secret
+#   2. $WORKDIR/aws-secret-application
+#
+# 2 are shipped through flux-config and are Global properties:
+#   3. $WORKDIR/global-aws-parameter-store
+#   4. $WORKDIR/global-aws-secret
 
 # For aws-parameter-store, we strip the first character since it's always a '_'
 log "Loading AWS Parameter Store variables..."
 load_dir "$WORKDIR/aws-parameter-store" true 1
 log "Loaded AWS Parameter Store variables"
 
-log "Loading AWS Secret variables..."
-load_dir "$WORKDIR/aws-secret" true 0
-log "Loaded AWS Secret variables"
-
 log "Loading AWS Application Secret variables..."
 load_dir "$WORKDIR/aws-secret-application" false 0
 log "Loaded AWS Application Secret variables"