Skip to content

fix: silent error discards in dir creation, trace output, and size calculation #19

@noahgift

Description

@noahgift

Kaizen Audit Findings

1. Silent writeln! error in create_remote_dirs (copia.rs:270)

writeln! to String returns Result but error silently discarded. If formatting fails, directory paths are silently dropped from the SSH mkdir list, causing subsequent transfers to fail with mysterious errors.

2. Silent trace record write failure (trace_output.rs:159)

NDJSON trace records written to file with errors silently discarded. Disk full, permission denied, etc. cause silent span loss in trace output.

3. Silent metadata errors corrupt size metrics (copia.rs:368-374)

compute_total_size() silently skips files where metadata() fails. Returns inaccurate total, corrupting progress/speed calculations.

Labels

  • kaizen
  • quality
  • bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions