Some of our client methods accept various types for inputs, for example in get_file(commit, path, URL), the commit can be a tuple, string, or Commit object. While we do some type checking with
|
def commit_from(src, allow_just_repo=False): |
, but this might break for users that specified an invalid string, or a string that got the order of repo and commit wrong.
In general, we want to add type checking where possible, and raise meaningful exceptions when inputs are not valid.
Some of our client methods accept various types for inputs, for example in
get_file(commit, path, URL), thecommitcan be a tuple, string, orCommitobject. While we do some type checking withpython-pachyderm/src/python_pachyderm/mixin/util.py
Line 4 in 8b5027d
In general, we want to add type checking where possible, and raise meaningful exceptions when inputs are not valid.