Improvements for translations

- comments for translators
- use placeholders instead of concatenating

Author: erikjv

src/gui/FoldersGui/accountfolderscontroller.cpp

@@ -170,6 +170,7 @@ void AccountFoldersController::buildMenuActions()
         connect(_chooseSync, &QAction::triggered, this, &AccountFoldersController::onChooseSync);
     }
 
+    //: This shows as 'Remove folder sync' or 'Remove Space sync'
     QString removeSyncString = tr("Remove %1 sync").arg(CommonStrings::space());
     _removeSync = new QAction(removeSyncString, this);
     _removeSync->setObjectName("removeFolderSyncAction");

src/gui/FoldersGui/accountfoldersview.cpp

@@ -53,6 +53,7 @@ AccountFoldersView::AccountFoldersView(QWidget *parent)
 void AccountFoldersView::buildView()
 {
     QVBoxLayout *mainLayout = new QVBoxLayout();
+    //: This shows as 'Folder sync' or 'Space sync'
     QString titleString = tr("%1 sync").arg(CommonStrings::capSpace());
     QLabel *titleLabel = new QLabel(titleString, this);
     QFont f = titleLabel->font();
@@ -67,6 +68,7 @@ void AccountFoldersView::buildView()
     description->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
     buttonLineLayout->addWidget(description, 0, Qt::AlignLeft);
 
+    //: This shows as 'Add new folder sync…' or 'Add new Space sync…'
     QString addSyncString = tr("Add new %1 sync…").arg(CommonStrings::space());
     _addFolderButton = new QPushButton(addSyncString, this);
     _addFolderButton->setObjectName("addFolderSyncButton");

src/gui/FoldersGui/folderitem.cpp

@@ -204,10 +204,9 @@ QVariant FolderItem::data(int role) const
     case Qt::DisplayRole:
         return _folder->displayName();
     case Qt::AccessibleTextRole: {
-        QString accessible = _folder->displayName();
-        accessible.append(tr(" sync status "));
-        accessible.append(_statusString);
-        return accessible;
+        //: Accessible text, read out by a screen reader.
+        //~ The first argument is the displayed name of the folder.
+        return tr("%1, sync status: %2").arg(_folder->displayName(), _statusString);
     }
     case Qt::DecorationRole:
         return _image;

src/gui/FoldersGui/folderitemupdater.cpp

@@ -104,8 +104,7 @@ void FolderItemUpdater::onSyncStateChanged()
                we " "can't update a known total size using these progress values becausethey are never negative, to indicate a removal"; QStandardItem
                *errorItem = new QStandardItem(errorIcon, longError);
             */
-            QString accessibleError = tr("Sync error: ");
-            accessibleError.append(error);
+            QString accessibleError = tr("Sync error: %1").arg(error);
             errorItem->setData(accessibleError, Qt::AccessibleTextRole);
 
             QStandardItem *emptyEditorItem = new QStandardItem();