Merge pull request #2 from ovh/portFilter

add fixedIPs filter on network port

Author: reenjii

openstack/networking/v2/ports/requests.go

@@ -1,6 +1,10 @@
 package ports
 
 import (
+	"fmt"
+	"net/url"
+	"strings"
+
 	"github.com/gophercloud/gophercloud"
 	"github.com/gophercloud/gophercloud/pagination"
 )
@@ -36,11 +40,37 @@ type ListOpts struct {
 	TagsAny      string `q:"tags-any"`
 	NotTags      string `q:"not-tags"`
 	NotTagsAny   string `q:"not-tags-any"`
+	FixedIPs     []FixedIPOpts
+}
+
+type FixedIPOpts struct {
+	IPAddress       string
+	IPAddressSubstr string
+	SubnetID        string
+}
+
+func (f FixedIPOpts) String() string {
+	var res []string
+	if f.IPAddress != "" {
+		res = append(res, fmt.Sprintf("ip_address=%s", f.IPAddress))
+	}
+	if f.IPAddressSubstr != "" {
+		res = append(res, fmt.Sprintf("ip_address_substr=%s", f.IPAddressSubstr))
+	}
+	if f.SubnetID != "" {
+		res = append(res, fmt.Sprintf("subnet_id=%s", f.SubnetID))
+	}
+	return strings.Join(res, ",")
 }
 
 // ToPortListQuery formats a ListOpts into a query string.
 func (opts ListOpts) ToPortListQuery() (string, error) {
 	q, err := gophercloud.BuildQueryString(opts)
+	params := q.Query()
+	for _, fixedIP := range opts.FixedIPs {
+		params.Add("fixed_ips", fixedIP.String())
+	}
+	q = &url.URL{RawQuery: params.Encode()}
 	return q.String(), err
 }
 

openstack/networking/v2/ports/testing/requests_test.go

@@ -3,6 +3,7 @@ package testing
 import (
 	"fmt"
 	"net/http"
+	"net/url"
 	"testing"
 
 	fake "github.com/gophercloud/gophercloud/openstack/networking/v2/common"
@@ -784,3 +785,19 @@ func TestUpdateWithExtraDHCPOpts(t *testing.T) {
 	th.AssertDeepEquals(t, s.ExtraDHCPOpts[0].OptValue, "value2")
 	th.AssertDeepEquals(t, s.ExtraDHCPOpts[0].IPVersion, 4)
 }
+
+func TestPortsListOpts(t *testing.T) {
+	for expected, opts := range map[string]ports.ListOpts{
+		newValue("fixed_ips", `ip_address=1.2.3.4,subnet_id=42`): ports.ListOpts{
+			FixedIPs: []ports.FixedIPOpts{{IPAddress: "1.2.3.4", SubnetID: "42"}},
+		},
+	} {
+		actual, _ := opts.ToPortListQuery()
+		th.AssertEquals(t, expected, actual)
+	}
+}
+func newValue(param, value string) string {
+	v := url.Values{}
+	v.Add(param, value)
+	return "?" + v.Encode()
+}