fix: pass false to transaction if is not supported in engine

Author: oskar-gmerek

packages/surreal-better-auth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "surreal-better-auth",
-  "version": "2.0.0-beta.4",
+  "version": "2.0.0-beta.6",
   "author": {
     "name": "Oskar Gmerek",
     "url": "https://oskargmerek.com",
@@ -51,8 +51,6 @@
   "scripts": {
     "build": "tsdown",
     "build:watch": "tsdown --watch",
-    "test": "vitest run tests/ --fileParallelism=false",
-    "test:plugins": "vitest run tests/plugins/",
     "postinstall": "node welcome.js"
   },
   "type": "module",

packages/surreal-better-auth/src/adapter.ts

@@ -302,74 +302,69 @@ export const surrealdbAdapter = (db: Surreal, config?: SurrealDBAdapterConfig) =
       };
     };
 
-  const adapterOptions: AdapterFactoryOptions = {
-    config: {
-      adapterId: "surrealdb",
-      adapterName: "SurrealDB",
-      usePlural: config?.usePlural ?? false,
-      debugLogs: config?.debugLogs ?? false,
-      supportsJSON: true,
-      supportsArrays: true,
-      supportsUUIDs: false,
-      // @ts-expect-error
-      supportsJoin: true,
-      supportsDates: true,
-      supportsBooleans: true,
-      supportsNumericIds: true,
-      customIdGenerator: config?.idGenerator
-        ? () => {
-            return "__surreal__";
+  return (options: any): DBAdapter => {
+    const supportsTx = db.isFeatureSupported(Features.Transactions);
+
+    const adapterOptions: AdapterFactoryOptions = {
+      config: {
+        adapterId: "surrealdb",
+        adapterName: "SurrealDB",
+        usePlural: config?.usePlural ?? false,
+        debugLogs: config?.debugLogs ?? false,
+        supportsJSON: true,
+        supportsArrays: true,
+        supportsUUIDs: false,
+        // @ts-expect-error
+        supportsJoin: true,
+        supportsDates: true,
+        supportsBooleans: true,
+        supportsNumericIds: true,
+        customIdGenerator: config?.idGenerator
+          ? () => {
+              return "__surreal__";
+            }
+          : undefined,
+
+        /**
+         * Transforms SurrealDB specific types back to standard JavaScript types.
+         * Converts RecordId to string and Surreal DateTime to native Date.
+         */
+        customTransformOutput: ({ data }) => {
+          if (data instanceof RecordId || data instanceof StringRecordId) {
+            return data.toString();
           }
-        : undefined,
-      /**
-       * Transforms SurrealDB specific types back to standard JavaScript types.
-       * Converts RecordId to string and Surreal DateTime to native Date.
-       */
-      customTransformOutput: ({ data }) => {
-        if (data instanceof RecordId || data instanceof StringRecordId) {
-          return data.toString();
-        }
 
-        if (data instanceof DateTime) {
-          return data.toDate();
-        }
-
-        return data;
-      },
-      /**
-       * Wraps adapter operations in a SurrealDB transaction.
-       */
-      transaction: async (cb) => {
-        // Check if transactions are supported by the engine.
-        if (!db.isFeatureSupported(Features.Transactions)) {
-          // If not supported, use a base adapter and execute sequentially.
-          const baseAdapter = lazyAdapter(authOptions);
-          return await cb(baseAdapter);
-        }
+          if (data instanceof DateTime) {
+            return data.toDate();
+          }
 
-        // If transactions are supported, use a transactional adapter.
-        const txn = await db.beginTransaction();
-        try {
-          const transactionalAdapter = createAdapterFactory({
-            config: adapterOptions.config,
-            adapter: createCustomAdapter(txn),
-          })(authOptions);
-
-          const result = await cb(transactionalAdapter);
-          await txn.commit();
-          return result;
-        } catch (err) {
-          await txn.cancel();
-          throw err;
-        }
+          return data;
+        },
+        /**
+         * Wraps adapter operations in a SurrealDB transaction.
+         */
+        transaction: supportsTx
+          ? async (cb) => {
+              const txn = await db.beginTransaction();
+              try {
+                const transactionalAdapter = createAdapterFactory({
+                  config: adapterOptions.config,
+                  adapter: createCustomAdapter(txn),
+                })(authOptions);
+
+                const result = await cb(transactionalAdapter);
+                await txn.commit();
+                return result;
+              } catch (err) {
+                await txn.cancel();
+                throw err;
+              }
+            }
+          : false,
       },
-    },
-    adapter: createCustomAdapter(db),
-  };
-
-  const lazyAdapter = createAdapterFactory(adapterOptions);
+      adapter: createCustomAdapter(db),
+    };
 
-  return (options: any): DBAdapter => {
-    return lazyAdapter(options);
+    return createAdapterFactory(adapterOptions)(options);
   };
 };