Replies: 2 comments 1 reply
-
|
fast-gateway-protocol/browser#2 |
Beta Was this translation helpful? Give feedback.
-
|
Hey, thanks for this — and for the two PRs on browser! Just merged both. The On the On the Appreciate the thoughtful writeup and the PRs! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Suggestion: Prefix repo names with
fgp-before the project growsHey! First off, really cool project. The daemon-based approach to replacing MCP stdio is a great idea and the benchmarks speak for themselves. Excited to see where this goes.
Since the project is still early, it might be worth renaming the GitHub repos to match the crates.io names (e.g.
browser→fgp-browser,daemon→fgp-daemon, etc.). Right now names likedaemon,browser, andgithubare super generic. On a Linux machinedaemonespecially just blends into the woodwork, and finding the right repo on GitHub is tough when the name could be anything. The crates.io packages already use thefgp-prefix, so aligning now while there are few stars/forks would be painless (GitHub auto-redirects old URLs).Separately, I noticed that
browserandgithubusepath = "../daemon"in theirCargo.tomlwhich breaks on a standalone clone, whiletravel/cli/fly/neonusegit =URLs that work fine, and thefgpmonorepo has 24 subdirs pointing at a../daemonthat doesn't exist in the repo. Standardizing ongit =or crates.io version deps would make everything build independently.Suggested changes:
fgp-prefix (browser→fgp-browser,daemon→fgp-daemon,github→fgp-github,cli→fgp-cli,travel→fgp-travel,fly→fgp-fly,neon→fgp-neon,calendar→fgp-calendar,gmail→fgp-gmail,protocol→fgp-protocol,daemon-py→fgp-daemon-py)browserandgithubCargo.toml frompath = "../daemon"togit =or crates.io version deps so they build without a sibling clonefgpmonorepo that referencepath = "../daemon"with nodaemon/dir present; either add a workspace Cargo.toml or switch to registry depsHappy to put together a PR for both the renames and the Cargo.toml migration if you're open to it, just let me know!
Beta Was this translation helpful? Give feedback.
All reactions