After recently fixing some issues in PolynomialPathFitter, it is becoming increasingly clear that the current implementation of the path fitting pipeline is a bit unwieldy and somewhat hard to maintain. Additionally, there are certain potential improvements to path fitting that the current implementation will make it hard to integrate. Below is a list of maintenance changes that would bring PolynomialPathFitter into a healthier state. Following that is a list of features suggested previously be Ton van den Bogert and other users.
Maintenance improvements
Regarding modularization, each step could have their own internal/private class to improve maintainability and make unit testing easier. These classes could possibly be moved into osimCommon proper to facilitate this.
New features and performance improvements
After recently fixing some issues in
PolynomialPathFitter, it is becoming increasingly clear that the current implementation of the path fitting pipeline is a bit unwieldy and somewhat hard to maintain. Additionally, there are certain potential improvements to path fitting that the current implementation will make it hard to integrate. Below is a list of maintenance changes that would bringPolynomialPathFitterinto a healthier state. Following that is a list of features suggested previously be Ton van den Bogert and other users.Maintenance improvements
PolynomialPathFitter.cpp. (RefactorPolynomialPathFitter#4302)Regarding modularization, each step could have their own internal/private class to improve maintainability and make unit testing easier. These classes could possibly be moved into
osimCommonproper to facilitate this.New features and performance improvements
AbstractGeometryPathutility for detecting dependent coordinates #4347,PolynomialPathFitter: use topology-based moment arm detection #4348 ).