Hey I'm working on this and would like some feedback on a draft/proposal.
So far I added a field AutoUpdate of type bool to the InstrumentationSpec. By default this would be disabled.

Next, I introduced a reconciler to update corresponding pods when an InstrumentationSpec is created, deleted or modified.
To verify that a pod configuration is up-to-date, I store the sha256 sum of the configuration in an annotation.

Originally I thought if the sha256 sum of the InstrumentationSpec in the pod annotaion differs, I would force the restart by updating the annotation. Unfortunately, this does not work on the pod basis itself. My next thought was to realize it via DaemonSet and Deployment. However, this excludes differently created pods.
Do you have any idea how to solve the problem?

A solution could be to use the ownerID to search for the "highest" object that contains a pod specification and change the pod annotation there. However, this way seems to me to be a "dirty hack" that still would not work on standalone pods without an owner.

Another could be to simply delete the pod that needs an update. To handle the pod standalone issue, we can simply recreate those pods. What scares me, what if delete works fine, but create fails?
we could store the PodSpec on some place, then try to delete the pod and if it fails, we can return an error and in the next reconcile call we try again.

ref := p.GetOwnerReferences()
copy := p.DeepCopy()
if err := r.Client.Delete(ctx, &p); err != nil {
	panic(err)
}
if len(ref) == 0 {
	if err := r.Client.Create(ctx, copy); err != nil {
		panic(err)
	}
}

Add option to Instrumentation CR to restart depoyments if config changes #553

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions