State of the package?

[guettli]

There are several open issues and no update to the source for years.

What is the state of the package?

Is there a maintained alternative?

[yolken-airplane]

I was wondering the same thing, and found the following, which appears to be a well-maintained fork: https://github.com/klauspost/compress/tree/master/gzhttp.

[linux019]

Yes this lib isn't optimized well. The problem of this lib that it doesn't use pool for this object with a slice inside

gziphandler/gzip.go

Line 326 in 2f8bb1d

gw := &GzipResponseWriter{

and this leads to huge reallocations

There are benchmarks with compression of 64kb , Klauspost is the winner everywhere

BenchmarkNYGzip
BenchmarkKlausPostGzip
PASS
benchmark                     iter        time/iter   bytes alloc        allocs
---------                     ----        ---------   -----------        ------
BenchmarkNYGzip-18           86682   12753.00 ns/op    66091 B/op   8 allocs/op
BenchmarkKlausPostGzip-18   736071    1490.00 ns/op      113 B/op   1 allocs/op

package compression_test

import (
	"bytes"
	"net/http"
	"net/http/httptest"
	"testing"

	"github.com/NYTimes/gziphandler"
	"github.com/klauspost/compress/gzhttp"
	"github.com/klauspost/compress/gzip"
)

type testHttpHandle struct {
	data []byte
}

func (t testHttpHandle) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	w.Header().Set("Content-Type", "application/octet-stream")
	w.Write(t.data)
}

func BenchmarkNYGzip(b *testing.B) {
	srv := new(testHttpHandle)
	h := gziphandler.GzipHandler(srv)
	body := new(bytes.Buffer)
	srv.data = make([]byte, 65536)
	for i := 0; i < len(srv.data); i++ {
		srv.data[i] = byte(i)
	}

	req := httptest.NewRequest(http.MethodPost, "/", body)
	req.Header.Set("Accept-Encoding", "gzip")
	rec := httptest.NewRecorder()
	b.ResetTimer()
	b.ReportAllocs()
	for n := 0; n < b.N; n++ {
		rec.Body.Reset()
		h.ServeHTTP(rec, req)
	}
}
func BenchmarkKlausPostGzip(b *testing.B) {
	srv := new(testHttpHandle)
	wrapper, _ := gzhttp.NewWrapper(gzhttp.MinSize(2000), gzhttp.CompressionLevel(gzip.DefaultCompression))
	h := wrapper(srv)
	body := new(bytes.Buffer)
	srv.data = make([]byte, 65536)
	for i := 0; i < len(srv.data); i++ {
		srv.data[i] = byte(i)
	}

	req := httptest.NewRequest(http.MethodPost, "/", body)
	req.Header.Set("Accept-Encoding", "gzip")
	rec := httptest.NewRecorder()
	b.ResetTimer()
	b.ReportAllocs()
	for n := 0; n < b.N; n++ {
		rec.Body.Reset()
		h.ServeHTTP(rec, req)
	}
}

[jub0bs]

@linux019 If you want to see huge allocations, try sending the middleware a request with an Accept-Encoding header like

strings.Repeat(",", http.DefaultMaxHeaderBytes)

🤮

[linux019]

@jub0bs I switched to Klaus's lib, it works fine for me