Skip to content

Commit 93747b7

Browse files
committed
Use neutral readable lists for strengths and red flags
1 parent 75716f6 commit 93747b7

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

webapp.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -516,8 +516,8 @@ async def job_page(job_id: str):
516516
const prs = data.pr_analyses||[];
517517
const allPrs = data.all_prs||[];
518518
const repos = data.own_repos||[];
519-
const flags = (o.red_flags||[]).map(f=>`<span class="badge bg-red-900 text-red-200">${{linkifyRefText(f)}}</span>`).join(' ');
520-
const strengths = (o.strengths||[]).map(s=>`<span class="badge bg-green-900 text-green-200">${{linkifyRefText(s)}}</span>`).join(' ');
519+
const flags = (o.red_flags||[]).map(f=>`<li class="text-sm text-gray-300 bg-gray-800 rounded px-3 py-2">${{linkifyRefText(f)}}</li>`).join('');
520+
const strengths = (o.strengths||[]).map(s=>`<li class="text-sm text-gray-300 bg-gray-800 rounded px-3 py-2">${{linkifyRefText(s)}}</li>`).join('');
521521
const prRows = prs.map(p=>`<tr class="border-b border-gray-800 hover:bg-gray-800/40">
522522
<td class="py-2 px-3"><a href="${{p.url}}" target="_blank" class="text-blue-400 hover:underline text-sm">${{(p.title||'').slice(0,70)}}</a></td>
523523
<td class="py-2 px-3">${{clfBadge(p.classification)}}</td>
@@ -557,8 +557,8 @@ async def job_page(job_id: str):
557557
${{bar('Discussion Depth',o.discussion_depth||0)}}
558558
${{bar('Repo Quality',o.repo_quality||0)}}
559559
</div>
560-
${{flags?'<h3 class="text-sm font-semibold mt-4 text-red-400">Red Flags</h3><div class="flex flex-wrap gap-2 mt-1">'+flags+'</div>':''}}
561-
${{strengths?'<h3 class="text-sm font-semibold mt-3 text-green-400">Strengths</h3><div class="flex flex-wrap gap-2 mt-1">'+strengths+'</div>':''}}
560+
${{flags?'<h3 class="text-sm font-semibold mt-4">Red Flags</h3><ul class="mt-2 space-y-2">'+flags+'</ul>':''}}
561+
${{strengths?'<h3 class="text-sm font-semibold mt-3">Strengths</h3><ul class="mt-2 space-y-2">'+strengths+'</ul>':''}}
562562
</div>
563563
${{prs.length?`<div class="bg-gray-900 border border-gray-700 rounded-xl overflow-hidden mb-6">
564564
<div class="px-4 py-3 border-b border-gray-700 font-semibold">PRs Analyzed</div>
@@ -671,8 +671,8 @@ async def job_page(job_id: str):
671671
// render inline in panel instead
672672
const o=data.overall||{{}};
673673
const prs=data.pr_analyses||[];
674-
const flags=(o.red_flags||[]).map(f=>`<span class="badge bg-red-900 text-red-200">${{linkifyRefText(f)}}</span>`).join(' ');
675-
const strengths=(o.strengths||[]).map(s=>`<span class="badge bg-green-900 text-green-200">${{linkifyRefText(s)}}</span>`).join(' ');
674+
const flags=(o.red_flags||[]).map(f=>`<li class="text-sm text-gray-300 bg-gray-800 rounded px-3 py-2">${{linkifyRefText(f)}}</li>`).join('');
675+
const strengths=(o.strengths||[]).map(s=>`<li class="text-sm text-gray-300 bg-gray-800 rounded px-3 py-2">${{linkifyRefText(s)}}</li>`).join('');
676676
const prRows=prs.map(p=>`<tr class="border-b border-gray-800">
677677
<td class="py-1.5 px-2"><a href="${{p.url}}" target="_blank" class="text-blue-400 hover:underline text-xs">${{p.title.slice(0,60)}}</a></td>
678678
<td class="py-1.5 px-2">${{clfBadge(p.classification)}}</td>
@@ -686,8 +686,8 @@ async def job_page(job_id: str):
686686
${{bar('Discussion Depth',o.discussion_depth||0)}}
687687
${{bar('Repo Quality',o.repo_quality||0)}}
688688
<p class="text-sm text-gray-300 mt-3 mb-3">${{o.executive_summary||''}}</p>
689-
${{flags?'<div class="mb-2">'+flags+'</div>':''}}
690-
${{strengths?'<div class="mb-3">'+strengths+'</div>':''}}
689+
${{flags?'<h3 class="text-sm font-semibold mt-4 mb-2">Red Flags</h3><ul class="space-y-2 mb-3">'+flags+'</ul>':''}}
690+
${{strengths?'<h3 class="text-sm font-semibold mt-3 mb-2">Strengths</h3><ul class="space-y-2 mb-3">'+strengths+'</ul>':''}}
691691
${{prs.length?`<table class="w-full text-sm mt-2"><thead><tr class="text-left text-xs text-gray-400 border-b border-gray-700">
692692
<th class="py-1.5 px-2">PR</th><th class="py-1.5 px-2">Type</th><th class="py-1.5 px-2">Score</th>
693693
</tr></thead><tbody>${{prRows}}</tbody></table>`:''}}

0 commit comments

Comments
 (0)