use skipTest and version check for experimental features

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>

Author: bavulapati

implementors/node/features.js

@@ -1,8 +1,14 @@
 // Declares which experimental Node-API features this runtime supports.
 // Each key corresponds to a NODE_API_EXPERIMENTAL_HAS_* compile-time macro.
 // Other implementors should set unsupported features to false or omit them.
+
+const [major, minor] = process.version.slice(1).split('.').map(Number);
+
 globalThis.experimentalFeatures = {
-  sharedArrayBuffer: true,
+  // node_api_is_sharedarraybuffer and node_api_create_sharedarraybuffer were
+  // added in Node.js v24.9.0. Earlier versions do not export these symbols,
+  // causing addons that reference them to fail at dlopen time.
+  sharedArrayBuffer: major >= 25 || (major === 24 && minor >= 9),
   createObjectWithProperties: true,
   setPrototype: true,
   postFinalizer: true,

implementors/node/process.js

@@ -0,0 +1,7 @@
+const napiVersion = Number(process.versions.napi);
+
+const skipTest = () => {
+  process.exit(0);
+};
+
+Object.assign(globalThis, { napiVersion, skipTest });

implementors/node/tests.ts

@@ -34,6 +34,12 @@ const GC_MODULE_PATH = path.join(
   "node",
   "gc.js"
 );
+const PROCESS_MODULE_PATH = path.join(
+  ROOT_PATH,
+  "implementors",
+  "node",
+  "process.js"
+);
 const MUST_CALL_MODULE_PATH = path.join(
   ROOT_PATH,
   "implementors",
@@ -79,6 +85,8 @@ export function runFileInSubprocess(
         "--import",
         "file://" + GC_MODULE_PATH,
         "--import",
+        "file://" + PROCESS_MODULE_PATH,
+        "--import",
         "file://" + MUST_CALL_MODULE_PATH,
         filePath,
       ],

tests/js-native-api/test_sharedarraybuffer/test.js

@@ -1,88 +1,91 @@
 "use strict";
 
-if (experimentalFeatures.sharedArrayBuffer) {
-  const test_sharedarraybuffer = loadAddon("test_sharedarraybuffer");
+// SharedArrayBuffer support is an experimental feature.
+if (!experimentalFeatures.sharedArrayBuffer) {
+  skipTest();
+}
 
-  {
-    const sab = new SharedArrayBuffer(16);
-    const ab = new ArrayBuffer(16);
-    const obj = {};
-    const arr = [];
+const test_sharedarraybuffer = loadAddon("test_sharedarraybuffer");
 
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(sab),
-      true,
-    );
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(ab),
-      false,
-    );
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(obj),
-      false,
-    );
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(arr),
-      false,
-    );
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(null),
-      false,
-    );
-    assert.strictEqual(
-      test_sharedarraybuffer.TestIsSharedArrayBuffer(undefined),
-      false,
-    );
-  }
+{
+  const sab = new SharedArrayBuffer(16);
+  const ab = new ArrayBuffer(16);
+  const obj = {};
+  const arr = [];
 
-  // Test node_api_create_sharedarraybuffer
-  {
-    const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(16);
-    assert(sab instanceof SharedArrayBuffer);
-    assert.strictEqual(sab.byteLength, 16);
-  }
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(sab),
+    true,
+  );
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(ab),
+    false,
+  );
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(obj),
+    false,
+  );
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(arr),
+    false,
+  );
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(null),
+    false,
+  );
+  assert.strictEqual(
+    test_sharedarraybuffer.TestIsSharedArrayBuffer(undefined),
+    false,
+  );
+}
 
-  // Test node_api_create_get_sharedarraybuffer_info
-  {
-    const sab = new SharedArrayBuffer(32);
-    const byteLength = test_sharedarraybuffer.TestGetSharedArrayBufferInfo(sab);
-    assert.strictEqual(byteLength, 32);
-  }
+// Test node_api_create_sharedarraybuffer
+{
+  const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(16);
+  assert(sab instanceof SharedArrayBuffer);
+  assert.strictEqual(sab.byteLength, 16);
+}
+
+// Test node_api_create_get_sharedarraybuffer_info
+{
+  const sab = new SharedArrayBuffer(32);
+  const byteLength = test_sharedarraybuffer.TestGetSharedArrayBufferInfo(sab);
+  assert.strictEqual(byteLength, 32);
+}
 
-  // Test data access
-  {
-    const sab = new SharedArrayBuffer(8);
-    const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
-    assert.strictEqual(result, true);
+// Test data access
+{
+  const sab = new SharedArrayBuffer(8);
+  const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
+  assert.strictEqual(result, true);
 
-    // Check if data was written correctly
-    const view = new Uint8Array(sab);
-    for (let i = 0; i < 8; i++) {
-      assert.strictEqual(view[i], i % 256);
-    }
+  // Check if data was written correctly
+  const view = new Uint8Array(sab);
+  for (let i = 0; i < 8; i++) {
+    assert.strictEqual(view[i], i % 256);
   }
+}
 
-  // Test data pointer from existing SharedArrayBuffer
-  {
-    const sab = new SharedArrayBuffer(16);
-    const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
-    assert.strictEqual(result, true);
-  }
+// Test data pointer from existing SharedArrayBuffer
+{
+  const sab = new SharedArrayBuffer(16);
+  const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
+  assert.strictEqual(result, true);
+}
 
-  // Test zero-length SharedArrayBuffer
-  {
-    const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(0);
-    assert(sab instanceof SharedArrayBuffer);
-    assert.strictEqual(sab.byteLength, 0);
-  }
+// Test zero-length SharedArrayBuffer
+{
+  const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(0);
+  assert(sab instanceof SharedArrayBuffer);
+  assert.strictEqual(sab.byteLength, 0);
+}
 
-  // Test invalid arguments
-  {
-    assert.throws(
-      () => {
-        test_sharedarraybuffer.TestGetSharedArrayBufferInfo({});
-      },
-      { name: "Error", message: "Invalid argument" },
-    );
-  }
+// Test invalid arguments
+{
+  assert.throws(
+    () => {
+      test_sharedarraybuffer.TestGetSharedArrayBufferInfo({});
+    },
+    { name: "Error", message: "Invalid argument" },
+  );
 }