Skip to content

Commit e8a2f66

Browse files
committed
feat(footnotes): add footnote menu entry, move details to block submenu
Signed-off-by: Jonas <jonas@freesources.org>
1 parent 74dcd27 commit e8a2f66

2 files changed

Lines changed: 24 additions & 6 deletions

File tree

src/components/Menu/entries.ts

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import AssistantAction from './AssistantAction.vue'
1414
import EmojiPickerAction from './EmojiPickerAction.vue'
1515
import { isMobileDevice } from '../../helpers/isMobileDevice.js'
1616
import {
17+
Asterisk,
1718
CodeBrackets,
1819
CodeTags,
1920
Danger,
@@ -414,6 +415,19 @@ export function getMenuEntries(isRichWorkspace: boolean): MenuEntry[] {
414415
key: 'blocks-separator',
415416
isSeparator: true,
416417
},
418+
{
419+
key: 'details',
420+
label: t('text', 'Details'),
421+
isActive: 'details',
422+
icon: UnfoldMoreHorizontal,
423+
action: (command) => {
424+
return command.toggleDetails()
425+
},
426+
},
427+
{
428+
key: 'blocks-separator-2',
429+
isSeparator: true,
430+
},
417431
{
418432
key: 'math-inline',
419433
// TRANSLATORS Inline level math/science formula menu item, eg "something [the formula] something"
@@ -449,7 +463,7 @@ export function getMenuEntries(isRichWorkspace: boolean): MenuEntry[] {
449463
},
450464
},
451465
{
452-
key: 'math-separator',
466+
key: 'block-separator-3',
453467
isSeparator: true,
454468
},
455469
{
@@ -502,12 +516,14 @@ export function getMenuEntries(isRichWorkspace: boolean): MenuEntry[] {
502516
priority: 15,
503517
},
504518
{
505-
key: 'details',
506-
label: t('text', 'Details'),
507-
isActive: 'details',
508-
icon: UnfoldMoreHorizontal,
519+
key: 'footnote',
520+
label: t('text', 'Footnote'),
521+
keyChar: 'f',
522+
keyModifiers: [MODIFIERS.Mod, MODIFIERS.Shift],
523+
isActive: 'footnote',
524+
icon: Asterisk,
509525
action: (command) => {
510-
return command.toggleDetails()
526+
return command.insertFootnote()
511527
},
512528
priority: 16,
513529
},

src/components/icons.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import MDI_AlignHorizontalRight from 'vue-material-design-icons/AlignHorizontalR
1414
import MDI_AlphabeticalVariant from 'vue-material-design-icons/AlphabeticalVariant.vue'
1515
import MDI_Undo from 'vue-material-design-icons/ArrowULeftTop.vue'
1616
import MDI_Redo from 'vue-material-design-icons/ArrowURightTop.vue'
17+
import MDI_Asterisk from 'vue-material-design-icons/Asterisk.vue'
1718
import MDI_Check from 'vue-material-design-icons/Check.vue'
1819
import MDI_Positive from 'vue-material-design-icons/CheckboxMarkedCircle.vue'
1920
import MDI_CircleMedium from 'vue-material-design-icons/CircleMedium.vue'
@@ -101,6 +102,7 @@ export const AlphabeticalVariant = makeIcon(MDI_AlphabeticalVariant)
101102
export const AlignHorizontalCenter = makeIcon(MDI_AlignHorizontalCenter)
102103
export const AlignHorizontalLeft = makeIcon(MDI_AlignHorizontalLeft)
103104
export const AlignHorizontalRight = makeIcon(MDI_AlignHorizontalRight)
105+
export const Asterisk = makeIcon(MDI_Asterisk)
104106
export const Close = makeIcon(MDI_Close)
105107
export const Check = makeIcon(MDI_Check)
106108
export const CodeBrackets = makeIcon(MDI_CodeBrackets)

0 commit comments

Comments
 (0)