feat(governance): add automated tesst for network requests

should enable us to test the requests one by one and ensure we decode
properly the replies

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Author: mgallien

src/gui/governance/applygovernancelabel.cpp

@@ -21,6 +21,8 @@ void ApplyGovernanceLabel::start()
 
     connect(ocsGovernanceJob().data(), &OcsJob::jobFinished,
             this, &ApplyGovernanceLabel::jobDone);
+    connect(ocsGovernanceJob().data(), &OcsJob::ocsError,
+            this, &ApplyGovernanceLabel::finishedWitherror);
 
     ocsGovernanceJob()->setPath(buildPath());
     ocsGovernanceJob()->setMethod("POST");
@@ -35,7 +37,6 @@ void ApplyGovernanceLabel::jobDone(QJsonDocument reply, int statusCode)
 
     qCInfo(lcGovernance) << reply;
 
-
     Q_EMIT finished();
 }
 

src/gui/governance/deletegovernancelabel.cpp

@@ -21,6 +21,8 @@ void DeleteGovernanceLabel::start()
 
     connect(ocsGovernanceJob().data(), &OcsJob::jobFinished,
             this, &DeleteGovernanceLabel::jobDone);
+    connect(ocsGovernanceJob().data(), &OcsJob::ocsError,
+            this, &DeleteGovernanceLabel::ocsError);
 
     ocsGovernanceJob()->setPath(buildPath());
     ocsGovernanceJob()->setMethod("DELETE");
@@ -39,4 +41,14 @@ void DeleteGovernanceLabel::jobDone(QJsonDocument reply, int statusCode)
     Q_EMIT finished();
 }
 
+void DeleteGovernanceLabel::ocsError(int statusCode, const QString &message)
+{
+    Q_UNUSED(message)
+    Q_UNUSED(statusCode)
+
+    qCInfo(lcGovernance) << message;
+
+    Q_EMIT finished();
+}
+
 } // namespace OCC

src/gui/governance/deletegovernancelabel.h

@@ -27,6 +27,8 @@ public Q_SLOTS:
 
 private Q_SLOTS:
     void jobDone(QJsonDocument reply, int statusCode);
+
+    void ocsError(int statusCode, const QString &message);
 };
 
 } // namespace OCC

src/gui/governance/getavailablegovernancelabels.cpp

@@ -23,6 +23,8 @@ void GetAvailableGovernanceLabels::start()
 
     connect(ocsGovernanceJob().data(), &OcsJob::jobFinished,
             this, &GetAvailableGovernanceLabels::jobDone);
+    connect(ocsGovernanceJob().data(), &OcsJob::ocsError,
+            this, &GetAvailableGovernanceLabels::finishedWitherror);
 
     ocsGovernanceJob()->setPath(buildPath());
     ocsGovernanceJob()->setMethod("GET");

src/gui/governance/getgovernancelabels.cpp

@@ -21,6 +21,8 @@ void GetGovernanceLabels::start()
 
     connect(ocsGovernanceJob().data(), &OcsJob::jobFinished,
             this, &GetGovernanceLabels::jobDone);
+    connect(ocsGovernanceJob().data(), &OcsJob::ocsError,
+            this, &GetGovernanceLabels::finishedWitherror);
 
     ocsGovernanceJob()->setPath(buildPath());
     ocsGovernanceJob()->setMethod("GET");
@@ -35,7 +37,6 @@ void GetGovernanceLabels::jobDone(QJsonDocument reply, int statusCode)
 
     qCInfo(lcGovernance) << reply;
 
-
     Q_EMIT finished();
 }
 

src/gui/governance/governancenetworkjob.h

@@ -89,6 +89,8 @@ class GovernanceNetworkJob : public QObject
 
     void finished();
 
+    void finishedWitherror(int errorCode, const QString &errorMessage);
+
     void accountChanged();
 
 protected:

test/CMakeLists.txt

@@ -77,6 +77,7 @@ nextcloud_add_test(AllFilesDeleted)
 nextcloud_add_test(Blacklist)
 nextcloud_add_test(LocalDiscovery)
 nextcloud_add_test(RemoteDiscovery)
+nextcloud_add_test(Governance)
 
 if (NOT APPLE)
     nextcloud_add_test(Permissions)