Fixed Falcon multipart

Author: mr-fatalyst

fastopenapi/routers/falcon/extractors.py

@@ -8,6 +8,8 @@
     BaseRequestDataExtractor,
 )
 
+_MULTIPART_CACHE_ATTR = "_fastopenapi_multipart_cache"
+
 
 class FalconRequestDataExtractor(BaseRequestDataExtractor):
     @classmethod
@@ -51,49 +53,70 @@ def _get_body(cls, request: Any) -> dict | list | None:
         return {}
 
     @classmethod
-    def _get_form_data(cls, request: Any) -> dict:
-        """Extract form data"""
-        form_data = {}
-        ct = (request.content_type or "").lower()
+    def _parse_multipart(
+        cls, request: Any
+    ) -> tuple[dict, dict[str, FileUpload | list[FileUpload]]]:
+        """Parse multipart stream once and cache the result on the request."""
+        cached = getattr(request, _MULTIPART_CACHE_ATTR, None)
+        if isinstance(cached, tuple):
+            return cached
 
-        if ct == "application/x-www-form-urlencoded":
-            form_data = request.media or {}
-
-        return form_data
-
-    @classmethod
-    def _get_files(cls, request: Any) -> dict[str, FileUpload | list[FileUpload]]:
-        """Extract files from Falcon request (sync)"""
-        files = {}
-        ct = (request.content_type or "").lower()
+        form_data = {}
+        files: dict[str, FileUpload | list[FileUpload]] = {}
 
-        if "multipart/form-data" in ct and hasattr(request, "get_media"):
-            form = request.get_media()
-            for part in form:
-                filename = getattr(part, "secure_filename", None) or getattr(
-                    part, "filename", None
-                )
-                if not filename:
-                    continue
+        form = request.get_media()
+        for part in form:
+            filename = getattr(part, "secure_filename", None) or getattr(
+                part, "filename", None
+            )
+            field_name = getattr(part, "name", filename)
 
+            if filename:
                 content = part.stream.read()
                 file_upload = FileUpload(
                     filename=filename,
                     content_type=getattr(part, "content_type", None),
                     size=len(content),
                     file=content,
                 )
-
-                field_name = getattr(part, "name", filename)
                 if field_name in files:
                     if isinstance(files[field_name], list):
                         files[field_name].append(file_upload)
                     else:
                         files[field_name] = [files[field_name], file_upload]
                 else:
                     files[field_name] = file_upload
+            else:
+                form_data[field_name] = part.text
+
+        result = (form_data, files)
+        setattr(request, _MULTIPART_CACHE_ATTR, result)
+        return result
 
-        return files
+    @classmethod
+    def _get_form_data(cls, request: Any) -> dict:
+        """Extract form data"""
+        ct = str(request.content_type or "").lower()
+
+        if ct == "application/x-www-form-urlencoded":
+            return request.media or {}
+
+        if "multipart/form-data" in ct and hasattr(request, "get_media"):
+            form_data, _ = cls._parse_multipart(request)
+            return form_data
+
+        return {}
+
+    @classmethod
+    def _get_files(cls, request: Any) -> dict[str, FileUpload | list[FileUpload]]:
+        """Extract files from Falcon request (sync)"""
+        ct = str(request.content_type or "").lower()
+
+        if "multipart/form-data" in ct and hasattr(request, "get_media"):
+            _, files = cls._parse_multipart(request)
+            return files
+
+        return {}
 
 
 class FalconAsyncRequestDataExtractor(