Skip to content

Commit 190c9ee

Browse files
committed
Fixed headers and values for response with code 204
1 parent 8db1205 commit 190c9ee

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

fastopenapi/routers/base.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,10 @@ def handle_request(self, endpoint: Callable, env: RequestEnvelope) -> Any:
8888
result = self._validate_response(result, response_model)
8989
if self.is_framework_response(result):
9090
return result
91+
response = self.response_builder_cls.build(result, endpoint.__route_meta__)
9192
if route_meta.get("status_code") == 204:
92-
return self.build_framework_response(
93-
Response(status_code=204, content=None)
94-
)
95-
else:
96-
response = self.response_builder_cls.build(
97-
result, endpoint.__route_meta__
98-
)
99-
return self.build_framework_response(response)
93+
response.content = None
94+
return self.build_framework_response(response)
10095
except Exception as e:
10196
api_error = APIError.from_exception(e, self.EXCEPTION_MAPPER)
10297
return self.build_framework_response(
@@ -125,13 +120,10 @@ async def handle_request_async(
125120
result = self._validate_response(result, response_model)
126121
if self.is_framework_response(result):
127122
return result
123+
response = self.response_builder_cls.build(result, route_meta)
128124
if route_meta.get("status_code") == 204:
129-
return self.build_framework_response(
130-
Response(status_code=204, content=None)
131-
)
132-
else:
133-
response = self.response_builder_cls.build(result, route_meta)
134-
return self.build_framework_response(response)
125+
response.content = None
126+
return self.build_framework_response(response)
135127
except Exception as e:
136128
api_error = APIError.from_exception(e, self.EXCEPTION_MAPPER)
137129
return self.build_framework_response(

0 commit comments

Comments
 (0)