review and refactor handler

Author: meyerjrr

pkg/event/event.go

@@ -21,9 +21,10 @@ type CommentEvent struct {
 	CommentBody string
 	// CommentAuthor is the login of the comment author.
 	CommentAuthor string
-
 	// IsReviewComment indicates this came from a pull_request_review_comment event.
 	IsReviewComment bool
+	// IsReviewComment indicates this came from a pull_request_review_comment event.
+	IsIssueComment bool
 	// DiffHunk is the diff hunk associated with a review comment (empty for issue comments).
 	DiffHunk string
 	// FilePath is the file path associated with a review comment (empty for issue comments).

pkg/event/issue_comment.go

@@ -58,5 +58,6 @@ func parseIssueComment(eventPath string) (*CommentEvent, error) {
 		IsReviewComment: false,
 		KeywordDetected: detected,
 		SkillOverride:   skillOverride,
+		IsIssueComment:  true,
 	}, nil
 }

pkg/event/review_comment.go

@@ -57,5 +57,6 @@ func parseReviewComment(eventPath string) (*CommentEvent, error) {
 		Line:            payload.Comment.Line,
 		KeywordDetected: detected,
 		SkillOverride:   skillOverride,
+		IsIssueComment:  false,
 	}, nil
 }

pkg/handler/handler.go

@@ -36,7 +36,6 @@ func New(token, claudeKey, claudeModel string, dryRun bool, skillsDir string) *H
 	}
 }
 
-// ClassifyResult holds the classification outputs for use by callers.
 type ClassifyResult struct {
 	Detected     bool
 	SkillName    string
@@ -70,7 +69,7 @@ func (h *Handler) HandleGithubEvent(githubEventName, githubEventPath string) (*C
 
 	reactor := ghcontext.NewReactor(h.token)
 	if err := reactor.AddReaction(ctx, event.RepoOwner, event.RepoName, event.CommentID, event.IsReviewComment, "eyes"); err != nil {
-		log.Printf("Warning: failed to add eyes reaction: %v", err)
+		log.Printf("failed to add eyes reaction: %s", err)
 	}
 
 	var promptParams classifier.PromptParams
@@ -85,12 +84,13 @@ func (h *Handler) HandleGithubEvent(githubEventName, githubEventPath string) (*C
 		gh := ghcontext.New(h.token)
 		prCtx, err := gh.FetchPRContext(ctx, event.RepoOwner, event.RepoName, event.PRNumber)
 		if err != nil {
-			log.Printf("Warning: failed to gather PR context: %v", err)
+			log.Printf("failed to gather pr context: %v", err)
 			promptParams.PRTitle = "(unknown)"
 		} else {
 			promptParams.PRTitle = prCtx.PRTitle
 		}
-	} else {
+	}
+	if event.IsIssueComment {
 		gh := ghcontext.New(h.token)
 		prCtx, err := gh.FetchPRContext(ctx, event.RepoOwner, event.RepoName, event.PRNumber)
 		if err != nil {
@@ -101,17 +101,17 @@ func (h *Handler) HandleGithubEvent(githubEventName, githubEventPath string) (*C
 		promptParams.ChangedFiles = ghcontext.FormatChangedFiles(prCtx.ChangedFiles)
 	}
 
-	cls := classifier.New(h.claudeKey, h.claudeModel)
-	result, err := cls.Classify(ctx, promptParams)
+	claudeClassifier := classifier.New(h.claudeKey, h.claudeModel)
+	result, err := claudeClassifier.Classify(ctx, promptParams)
 	if err != nil {
 		if reactErr := reactor.AddReaction(ctx, event.RepoOwner, event.RepoName, event.CommentID, event.IsReviewComment, "confused"); reactErr != nil {
-			log.Printf("Warning: failed to add confused reaction: %v", reactErr)
+			log.Printf("failed to add confused reaction: %v", reactErr)
 		}
 		return nil, fmt.Errorf("classifying comment: %w", err)
 	}
 
 	if result.IsEmpty() {
-		log.Println("Comment not a substantive learning, skipping")
+		log.Println("comment not a substantive learning, skipping")
 		if err := setOutput("detected", "false"); err != nil {
 			return nil, err
 		}
@@ -174,8 +174,6 @@ func (h *Handler) HandleGithubEvent(githubEventName, githubEventPath string) (*C
 	}, nil
 }
 
-// listExistingSkills scans dir for subdirectories containing a SKILL.md file
-// and returns their directory names.
 func listExistingSkills(dir string) []string {
 	if dir == "" {
 		return nil
@@ -194,7 +192,6 @@ func listExistingSkills(dir string) []string {
 			if relErr != nil {
 				return nil
 			}
-			// Only include top-level skill directories (not nested paths).
 			if !strings.Contains(rel, string(os.PathSeparator)) {
 				skills = append(skills, rel)
 			}
@@ -204,7 +201,6 @@ func listExistingSkills(dir string) []string {
 	return skills
 }
 
-// setOutput writes a key=value pair to the GITHUB_OUTPUT file.
 func setOutput(key, value string) error {
 	outputFile := os.Getenv("GITHUB_OUTPUT")
 	if outputFile == "" {