Skip to content

Commit a069577

Browse files
oschwaldclaude
andcommitted
Remove -std=c99 from default CI builds
Our CI was using -std=c99 for all builds, which causes Darwin headers to hide BSD extension symbols. This masked the bswap32/bswap64 macro collision reported in #419, since real-world users (e.g. Homebrew) build without -std=c99 and see the conflict. Remove -std=c99 from the default CFLAGS so the main CI matrix matches what downstream consumers build with. Add a dedicated strict-C99 matrix entry (ubuntu/gcc) to preserve language compliance checking. Also change CMAKE_C_EXTENSIONS from OFF to ON to match default CMake behavior and what users get when building with cmake. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a291335 commit a069577

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
matrix:
1212
os: [ubuntu-latest, macos-latest]
1313
cc: [gcc, clang]
14-
posix: ['', -D_POSIX_C_SOURCE=200112L]
14+
posix: ['', -D_POSIX_C_SOURCE=200112L, -std=c99]
1515
name: Autotools build on ${{matrix.os}} using ${{matrix.cc}} ${{matrix.posix}}
1616
runs-on: ${{ matrix.os }}
1717
env:
@@ -29,7 +29,7 @@ jobs:
2929
- run: ./bootstrap
3030
- run: ./configure
3131
env:
32-
CFLAGS: -std=c99 -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter ${{ matrix.posix }}
32+
CFLAGS: -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter ${{ matrix.posix }}
3333
- run: make
3434
- run: make check
3535

0 commit comments

Comments
 (0)