Skip to content
This repository was archived by the owner on Feb 3, 2021. It is now read-only.

Input character not deletedย #200

@pikeas

Description

@pikeas

Current Behavior
This is the inverse of #179.

The smallest reproducible case I've found so far is to:

  • cd into a directory which triggers the AWS module
  • press "g"
  • press < tab >
  • press < delete >

Notice that the "g" remains displayed on screen but is not actually present in the buffer.

Expected Behavior
The first input character should not be displayed when deleted.

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER user dir host git package docker aws venv conda kubecontext exec_time battery vi_mode jobs char
set SPACEFISH_PROMPT_ADD_NEWLINE true

set -g fish_emoji_width 2

Environment

  • Spacefish version: 2.6.1
  • Fish version: 3.0.2
  • Fish plugin manager: fisher
  • Terminal emulator: iTerm 3.2.9
  • Operating system: OSX 10.14.5

Additional context/Screenshots

  • This happens with or without line_sep.
  • This does not happen if I change SPACEFISH_AWS_SYMBOL to a non-emoji.
  • Pasting the cloud emoji taken from the Spacefish function (โ˜๏ธ) into iTerm doesn't render well, but renders correctly when output by Spacefish.
  • The iTerm setting "Use Unicode version 9 widths" is checked.
  • Possibly related: Emoji issues in Fish 3.0ย fish-shell/fish-shell#5583

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugFix an existing bug

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions