Multiple weekdays `BYDAY` & ordinals `BYSETPOS` Problem

[perrelet]

Hi @marcbelletre,

I'm aware you put a lot of energy into #8 thank you for this 🙏

Unfortunately there's a pretty major issue with this implementation. If a user selects multiple weekdays (BYDAY) and multiple ordinal numbers (BYSETPOS) the returned occurrences aren't what the user expects. For example:

Produces the following dates:

Mon 4th Nov
Tues 5th Nov
Mon 11th Nov

However the user understandably expects:

Mon 4th Nov
Tues 5th Nov
Mon 11th Nov
Tues 12th Nov
Mon 18th Nov
Tues 19th Nov

This is because BYSETPOS does not represent weeks but simply the nth instance once you have calculated the instances corresponding to the remaining of the rule. It appears having both fields as a checkbox groups provides too much freedom to make selections that don't actually make logical sense.

1. The user should only be able to select a single BYDAY if they have selected multiple BYSETPOS.
2. The user shouldn't be able to set a BYSETPOS at all if they have set multiple BYDAY.

What are your thoughts?

[marcbelletre]

Hi @perrelet,

Sorry for the late response. I'm currently off of work for a few months and I don't read my emails very often ;)

You're right and I've never actually tested every possibility with this feature. I think setting multiple BYDAY does not make sense and maybe we should just replace checkbox buttons by radio buttons for this setting. It could be a breaking change for some users though.

Do you think of any other option?

Thank you for your help!

[perrelet]

Hi @marcbelletre,

Thanks for replying despite being away.

Yes - I agree that BYDAY should be a select field or radio buttons, however I also appreciate this is likely a breaking change for some. Perhaps you could provide a filter hook (e.g ACF/RRule/BYDAY/Multiple) in render.php to choose which type of HTML input is rendered?

Thoughts?

[marcbelletre]

Hi @perrelet,

I think this would need a deeper refactoring of the UI.

The best way to handle this might be to provide a UI that enables creating couples of BYSETPOS/BYDAY settings like in this example: https://icalendar.org/rrule-tool.html

But instead of having a single list of every options, we would have two lists:

• One with BYSETPOS options (first, second, third, fourth, fifth, last)
• One with BYDAY options (monday, tuesday, etc)

The UI would provide a "+" button to add more rows.

This would be a bit of work but it could be our best option. What do you think?

[perrelet]

Hi @marcbelletre,

Thanks for putting some thought into this.

Your proposal would solve the problem whilst retaining the flexibility. However I also recognize the heavy lifting that would be required to build the UI out. Would you use an ACF repeater field, or build a dedicated control?

I also wonder what the a11y implications might be?