editor.foreground not deferring to var(--shiki-code-normal)

[camplowell]

• The Plugin is up to date
• Obsidian is up to date

Describe the bug
Using an "empty" theme, the code foreground does not defer to var(--shiki-code-normal) but is instead hardcoded to #BBBBBB. This occurs even when Prefer theme colors is deactivated.

To Reproduce
Steps to reproduce the behavior:

• Add and use an "empty" or "blank" custom theme:

{
  "name": "Blank",
  "type": "both",
  "semanticHighlighting": true,
  "tokenColors": []
}

• Turn off Prefer Theme Colors
• Reload the highlighter

Expected:
All text in codeblocks have a foreground color matching var(--shiki-code-normal)

Actual:
All text in codeblocks have a foreground color hardcoded to #BBBBBB

Screenshots
Using light mode here to show that this can make it far less legible in some circumstances.

Occurs on

• Windows
• macOS
• Linux
• Android
• iOS

Plugin version
0.7.1

Additional context
Add any other context about the problem here.

[mProjectsCode]

That seems expected. The theme variables are only used for the Obsidian theme that ships with the plugin. A custom theme needs to specify its own colors, or it will get whatever Shiki defaults to.

[github-actions]

This issue is invalid. Please conform to the issue templates.

[camplowell]

Unfortunate. Can we get that documented somewhere?

This combined with the fact that everything in "tokenColors" accepts CSS variables, but "colors" doesn't (hex colors only) means that "type":"both" themes are essentially non-viable, and if you want to change any colors in your theme (including just for one language), you need to fully mirror your user overall Obsidian theme into a custom Shiki theme.

Edit: Alternatively, could Shiki change the defaults to:

• editor.foreground: var(--code-normal) (or Shiki equivalent CSS variable)
• editor.background: var(--code-background) (or Shiki equivalent CSS variable)