refactor(effect-lsp)!: adopt effect-utils full-strict Effect-LSP gate (remove errors-only override)

Removes LiveStore's temporary errors-only Effect-LSP override in genie/repo.ts
so the inherited effect-utils `effectDiagnosticsGate = { warnings: true,
suggestions: true }` applies in full: Effect errors, warnings, AND suggestions
now all gate `tsgo --build`. The LiveStore-specific
`allowedDuplicatedPackages: ['@livestore/utils']` is folded into the base
plugin config so it survives the override removal.

This is the capstone of the #811 Effect-LSP burndown; it lands on top of the
three burndown merges (#1407 mechanical, #1408 schema, #1409 semantic) which
together cleared all ~406 pre-existing advisory diagnostics. Regenerated all 28
package tsconfigs via genie:run.

Acceptance test: with the override removed, `tsgo --build --force
tsconfig.dev.json` builds all 32 projects and exits 0 with zero Effect
diagnostics; `devenv tasks run ts:check` and `check:quick` are green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017UUpxCn21wCGq67x3Yy48A

Author: schickling-assistant

.changeset/empty-effect-lsp-full-gate.md

@@ -0,0 +1,4 @@
+---
+---
+
+No release impact (Effect-LSP gate). Adopts effect-utils' full `effectDiagnosticsGate` (errors + warnings + suggestions) by removing LiveStore's temporary errors-only override in `genie/repo.ts`.

docs/src/content/_assets/code/tsconfig.json

@@ -90,7 +90,8 @@ export const domLib = effectUtilsDomLib.filter((lib) => lib !== 'DOM.Iterable' &
 
 // Strip inherited options that now match defaults so generated
 // tsconfigs only carry LiveStore-specific intent. `plugins` is pulled out
-// separately so we can override the Effect-LSP exit-code gate below.
+// separately so we can inject LiveStore's `allowedDuplicatedPackages` onto the
+// inherited `@effect/language-service` plugin below (without altering its gate).
 const {
   allowJs: _allowJs,
   esModuleInterop: _esModuleInterop,
@@ -103,30 +104,31 @@ const {
 } = effectUtilsBaseTsconfigCompilerOptions
 
 /**
- * #811 Effect-LSP gate — deferred warning/suggestion burndown.
+ * #811 Effect-LSP gate — full effect-utils bar adopted (errors-only override removed).
  *
  * effect-utils sets `effectDiagnosticsGate = { warnings: true, suggestions: true }`,
  * so its `@effect/language-service` plugin config fails `tsgo --build` on every
- * Effect *warning* and *suggestion*, not just errors. Adopting this effect-utils
- * revision surfaced ~406 pre-existing advisory diagnostics (duplicatePackage,
- * schemaNumber, preferSchemaOverJson, …) across the LiveStore tree.
+ * Effect *error*, *warning*, and *suggestion*. Adopting the effect-utils bump
+ * originally surfaced ~406 pre-existing advisory diagnostics (duplicatePackage,
+ * schemaNumber, preferSchemaOverJson, …) across the LiveStore tree, and we
+ * temporarily flipped `ignoreEffectWarningsInTscExitCode` /
+ * `ignoreEffectSuggestionsInTscExitCode` to restore an ERRORS-only gate while the
+ * burndown landed in dedicated PRs (mechanical / schema / semantic).
  *
- * For this effect-utils bump we restore LiveStore's pre-bump gating — ERRORS only —
- * by flipping just the two exit-code flags. Warnings/suggestions stay VISIBLE in
- * build output (advisory) but no longer fail the build; real Effect errors (e.g.
- * the `missingReturnYieldStar` bugs fixed in this PR) still gate hard via the
- * inherited `ignoreEffectErrorsInTscExitCode: false`. The full warning/suggestion
- * burndown to the #811 Effect-LSP bar is deferred to a dedicated follow-up PR.
- * This mirrors effect-utils' own `effectDiagnosticsGate` phased-adoption design.
+ * That burndown is now complete, so the override is REMOVED: warnings and
+ * suggestions gate `tsgo --build` again, and LiveStore inherits effect-utils'
+ * full `effectDiagnosticsGate` unchanged. Every remaining Effect warning/suggestion
+ * is either fixed or carries a justified inline `:off`. The only LiveStore-specific
+ * tweak we still inject here is `allowedDuplicatedPackages: ['@livestore/utils']`,
+ * which suppresses the expected `@livestore/utils` duplicate-package diagnostics
+ * that are intentional in this workspace.
  */
 const baseTsconfigCompilerOptions = {
   ...baseTsconfigCompilerOptionsWithoutPlugins,
   plugins: inheritedTsconfigPlugins.map((plugin) =>
     plugin.name === '@effect/language-service'
       ? {
           ...plugin,
-          ignoreEffectWarningsInTscExitCode: true,
-          ignoreEffectSuggestionsInTscExitCode: true,
           allowedDuplicatedPackages: ['@livestore/utils'],
         }
       : plugin,