-
Notifications
You must be signed in to change notification settings - Fork 333
Deleting a conflicted RGD stops reconciliation for the original RGD #1169
Copy link
Copy link
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Description
Summary
When two RGDs define the same Kind, the second one is rejected (Inactive). However, deleting the rejected RGD causes the original Active RGD to stop reconciling instances.
Reproduction
- create a RGD A points to CRD A
- create a RGD B also point to CRD A
Note B will be inactive as expected
-
delete RGD B
-
instances of CRD A will no longer reconicle
Controller logs after deletion:
DEBUG dynamic-controller Successfully unregistered GVR {"gvr": "kro.run/v1alpha1/myapps"}
INFO rgd-controller skipping CRD deletion because allowCRDDeletion is disabled
DEBUG rgd-controller setting resourcegraphdefinition as unmanaged {"name": "myapp-advanced"}
Expected Behavior
Deleting an Inactive/conflicted RGD should have no effect on the Active RGD that owns the CRD. The original RGD should continue reconciling instances normally.
Impact
- Deleting rejected/conflicted RGDs breaks original RGDs
- Restarting should fix this
Which option describes the most your issue?
ResourceGraphDefinition (Create, Update, Deletion)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.