-
Notifications
You must be signed in to change notification settings - Fork 676
OauthPopup: Typo "occured" and incorrect log level in error handlers #5053
Copy link
Copy link
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
The OauthPopup component has two error catch blocks with the following issues:
- Typo: "occured" should be "occurred" (missing 'r')
- Wrong log level:
console.logis used instead ofconsole.errorfor error handling - Inconsistent capitalization: Error messages don't follow standard capitalization
File: frontend/src/components/oidcauth/OauthPopup.tsx
Line 75 (current):
console.log('error occured while closing auth window', e);
Line 94 (current):
console.log('error occured while adding beforeunload event listener');
Using console.log for errors means they won't appear under the "Errors" filter in browser DevTools, making debugging harder.
To Reproduce
- Open frontend/src/components/oidcauth/OauthPopup.tsx
- See line 75 and line 94: both have the typo "occured" and use
console.log
Environment
- Installation type: Source (reviewing codebase on
mainbranch) - Headlamp Version: latest
main
Are you able to fix this issue?
Yes, I will propose a PR with the fix.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.