address review: use getValueInMap, fix log message, add unit test

Author: andyzhangx

pkg/azurefile/azurefile.go

@@ -881,20 +881,12 @@ func (d *Driver) GetAccountInfo(ctx context.Context, volumeID string, secrets, r
 	if protocol == nfs && fileShareName != "" {
 		// nfs protocol does not need account key, return directly
 		// unless createFolderIfNotExist is set with a folderName, which requires account key for data plane API
-		var needAccountKey bool
-		var hasFolder bool
-		for k, v := range reqContext {
-			switch strings.ToLower(k) {
-			case createFolderIfNotExistField:
-				needAccountKey = strings.EqualFold(v, trueValue)
-			case folderNameField:
-				hasFolder = v != ""
-			}
-		}
+		needAccountKey := strings.EqualFold(getValueInMap(reqContext, createFolderIfNotExistField), trueValue)
+		hasFolder := getValueInMap(reqContext, folderNameField) != ""
 		if !needAccountKey || !hasFolder {
 			return rgName, accountName, accountKey, fileShareName, diskName, subsID, tenantID, tokenFilePath, err
 		}
-		klog.V(2).Infof("NFS protocol with createFolderIfNotExist, fetching account key for data plane API")
+		klog.V(2).Infof("NFS protocol with createFolderIfNotExist may require an account key for data plane API access")
 	}
 
 	if secretNamespace == "" {

pkg/azurefile/azurefile_test.go

@@ -810,6 +810,24 @@ func TestGetAccountInfo(t *testing.T) {
 			expectFileShareName: "test_sharename",
 			expectDiskName:      "",
 		},
+		{
+			volumeID: "uniqe-volumeid-nfs-createfolder",
+			rgName:   "vol_nfs",
+			secrets:  emptySecret,
+			reqContext: map[string]string{
+				resourceGroupField:          "vol_nfs",
+				storageAccountField:         "test_accountname",
+				shareNameField:              "test_sharename",
+				protocolField:               "nfs",
+				createFolderIfNotExistField: "true",
+				folderNameField:             "testfolder",
+			},
+			expectErr:           false,
+			err:                 nil,
+			expectAccountName:   "test_accountname",
+			expectFileShareName: "test_sharename",
+			expectDiskName:      "",
+		},
 		{
 			volumeID: "invalid_getLatestAccountKey_value##",
 			rgName:   "vol_2",