-
Notifications
You must be signed in to change notification settings - Fork 169
Expand file tree
/
Copy pathcontrollerserver_test.go
More file actions
2731 lines (2495 loc) · 108 KB
/
controllerserver_test.go
File metadata and controls
2731 lines (2495 loc) · 108 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2020 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package azurefile
import (
"context"
"encoding/base64"
"fmt"
"net/http"
"reflect"
"runtime"
"strings"
"time"
"github.com/Azure/azure-sdk-for-go/sdk/azcore"
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v6"
armstorage "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2"
"github.com/container-storage-interface/spec/lib/go/csi"
"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"
"go.uber.org/mock/gomock"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/kubernetes/fake"
cloudprovider "k8s.io/cloud-provider"
"k8s.io/utils/ptr"
"sigs.k8s.io/azurefile-csi-driver/pkg/util"
"sigs.k8s.io/cloud-provider-azure/pkg/azclient"
"sigs.k8s.io/cloud-provider-azure/pkg/azclient/accountclient/mock_accountclient"
"sigs.k8s.io/cloud-provider-azure/pkg/azclient/fileshareclient/mock_fileshareclient"
"sigs.k8s.io/cloud-provider-azure/pkg/azclient/mock_azclient"
"sigs.k8s.io/cloud-provider-azure/pkg/azclient/subnetclient/mock_subnetclient"
azcache "sigs.k8s.io/cloud-provider-azure/pkg/cache"
"sigs.k8s.io/cloud-provider-azure/pkg/provider/config"
auth "sigs.k8s.io/cloud-provider-azure/pkg/provider/config"
"sigs.k8s.io/cloud-provider-azure/pkg/provider/storage"
)
var _ = ginkgo.Describe("TestCreateVolume", func() {
var d *Driver
var ctrl *gomock.Controller
stdVolCap := []*csi.VolumeCapability{
{
AccessType: &csi.VolumeCapability_Mount{
Mount: &csi.VolumeCapability_MountVolume{},
},
AccessMode: &csi.VolumeCapability_AccessMode{
Mode: csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER,
},
},
}
fakeShareQuota := int32(100)
stdVolSize := int64(5 * 1024 * 1024 * 1024)
stdCapRange := &csi.CapacityRange{RequiredBytes: stdVolSize}
lessThanPremCapRange := &csi.CapacityRange{RequiredBytes: int64(fakeShareQuota * 1024 * 1024 * 1024)}
var computeClientFactory *mock_azclient.MockClientFactory
var networkClientFactory *mock_azclient.MockClientFactory
var mockFileClient *mock_fileshareclient.MockInterface
ginkgo.BeforeEach(func() {
stdVolCap = []*csi.VolumeCapability{
{
AccessType: &csi.VolumeCapability_Mount{
Mount: &csi.VolumeCapability_MountVolume{},
},
AccessMode: &csi.VolumeCapability_AccessMode{
Mode: csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER,
},
},
}
fakeShareQuota = int32(100)
stdVolSize = int64(5 * 1024 * 1024 * 1024)
stdCapRange = &csi.CapacityRange{RequiredBytes: stdVolSize}
lessThanPremCapRange = &csi.CapacityRange{RequiredBytes: int64(fakeShareQuota * 1024 * 1024 * 1024)}
d = NewFakeDriver()
ctrl = gomock.NewController(ginkgo.GinkgoT())
computeClientFactory = mock_azclient.NewMockClientFactory(ctrl)
networkClientFactory = mock_azclient.NewMockClientFactory(ctrl)
networkClientFactory.EXPECT().GetSubnetClient().Return(mock_subnetclient.NewMockInterface(ctrl)).AnyTimes()
mockFileClient = mock_fileshareclient.NewMockInterface(ctrl)
computeClientFactory.EXPECT().GetFileShareClientForSub(gomock.Any()).Return(mockFileClient, nil).AnyTimes()
accountClient := mock_accountclient.NewMockInterface(ctrl)
computeClientFactory.EXPECT().GetAccountClient().Return(accountClient).AnyTimes()
computeClientFactory.EXPECT().GetAccountClientForSub(gomock.Any()).Return(accountClient, nil).AnyTimes()
var err error
d.cloud, err = storage.NewRepository(
config.Config{},
&azclient.Environment{},
nil,
computeClientFactory,
networkClientFactory,
)
d.kubeClient = fake.NewSimpleClientset()
gomega.Expect(err).NotTo(gomega.HaveOccurred())
})
ginkgo.AfterEach(func() {
ctrl.Finish()
})
ginkgo.When("Controller Capability missing", func() {
ginkgo.It("should fail", func(ctx context.Context) {
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-cap-missing",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: nil,
}
d.Cap = []*csi.ControllerServiceCapability{}
expectedErr := status.Errorf(codes.InvalidArgument, "CREATE_DELETE_VOLUME")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Volume name missing", func() {
ginkgo.It("should fail", func(ctx context.Context) {
req := &csi.CreateVolumeRequest{
Name: "",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: nil,
}
expectedErr := status.Error(codes.InvalidArgument, "CreateVolume Name must be provided")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Volume capabilities missing", func() {
ginkgo.It("should fail", func(ctx context.Context) {
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-missing",
CapacityRange: stdCapRange,
Parameters: nil,
}
expectedErr := status.Error(codes.InvalidArgument, "CreateVolume Volume capabilities not valid: CreateVolume Volume capabilities must be provided")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid volume capabilities", func() {
ginkgo.It("should fail", func(ctx context.Context) {
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: []*csi.VolumeCapability{
{
AccessType: &csi.VolumeCapability_Block{
Block: &csi.VolumeCapability_BlockVolume{},
},
AccessMode: &csi.VolumeCapability_AccessMode{
Mode: csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER,
},
},
},
Parameters: nil,
}
expectedErr := status.Error(codes.InvalidArgument, "CreateVolume Volume capabilities not valid: driver does not support block volumes")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Volume lock already present", func() {
ginkgo.It("should fail", func(ctx context.Context) {
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: nil,
}
locks := newVolumeLocks()
locks.locks.Insert(req.GetName())
d.volumeLocks = locks
expectedErr := status.Error(codes.Aborted, "An operation with the given Volume ID random-vol-name-vol-cap-invalid already exists")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Disabled fsType", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
fsTypeField: "test_fs",
secretNameField: "secretname",
pvcNamespaceKey: "pvcname",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
driverOptions := DriverOptions{
NodeID: fakeNodeID,
DriverName: DefaultDriverName,
EnableVHDDiskFeature: false,
}
d := NewFakeDriverCustomOptions(driverOptions)
expectedErr := status.Errorf(codes.InvalidArgument, "fsType storage class parameter enables experimental VDH disk feature which is currently disabled, use --enable-vhd driver option to enable it")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid fsType", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
fsTypeField: "test_fs",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
driverOptions := DriverOptions{
NodeID: fakeNodeID,
DriverName: DefaultDriverName,
EnableVHDDiskFeature: true,
}
d := NewFakeDriverCustomOptions(driverOptions)
expectedErr := status.Errorf(codes.InvalidArgument, "fsType(test_fs) is not supported, supported fsType list: [cifs smb nfs ext4 ext3 ext2 xfs]")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid protocol", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
protocolField: "test_protocol",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "protocol(test_protocol) is not supported, supported protocol list: [smb nfs]")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid PublicNetworkAccess", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
publicNetworkAccessField: "test_publicNetworkAccess",
}
req := &csi.CreateVolumeRequest{
Name: "PublicNetworkAccess-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "publicNetworkAccess(%s) is not supported, supported PublicNetworkAccess list: %v", "test_publicNetworkAccess", armstorage.PossiblePublicNetworkAccessValues())
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("nfs protocol only supports premium storage", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
protocolField: "nfs",
skuNameField: "Standard_LRS",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-nfs-protocol-standard-SKU",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "nfs protocol only supports premium storage, current account type: Standard_LRS")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid accessTier", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
protocolField: "smb",
accessTierField: "test_accessTier",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "shareAccessTier(test_accessTier) is not supported, supported ShareAccessTier list: [Cool Hot Premium TransactionOptimized]")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid rootSquashType", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
rootSquashTypeField: "test_rootSquashType",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "rootSquashType(test_rootSquashType) is not supported, supported RootSquashType list: [AllSquash NoRootSquash RootSquash]")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid fsGroupChangePolicy", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
fsGroupChangePolicyField: "test_fsGroupChangePolicy",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "fsGroupChangePolicy(test_fsGroupChangePolicy) is not supported, supported fsGroupChangePolicy list: [None Always OnRootMismatch]")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid shareNamePrefix", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
shareNamePrefixField: "-invalid",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "shareNamePrefix(-invalid) can only contain lowercase letters, numbers, hyphens, and length should be less than 21")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid accountQuota", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
accountQuotaField: "10",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "invalid accountQuota %d in storage class, minimum quota: %d", 10, minimumAccountQuota)
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid useDataPlaneAPI value", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
useDataPlaneAPIField: "invalid",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-useDataPlaneAPI-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "invalid %s: %s in storage class", useDataPlaneAPIField, "invalid")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("invalid tags format to convert to map", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
skuNameField: "premium",
resourceGroupField: "rg",
tagsField: "tags",
createAccountField: "true",
useSecretCacheField: "true",
enableLargeFileSharesField: "true",
pvcNameKey: "pvc",
pvNameKey: "pv",
shareNamePrefixField: "pre",
storageEndpointSuffixField: ".core",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
expectedErr := status.Errorf(codes.InvalidArgument, "Tags 'tags' are invalid, the format should like: 'key1=value1,key2=value2'")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Invalid protocol & fsType combination", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
protocolField: "nfs",
fsTypeField: "ext4",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
driverOptions := DriverOptions{
NodeID: fakeNodeID,
DriverName: DefaultDriverName,
EnableVHDDiskFeature: true,
}
d := NewFakeDriverCustomOptions(driverOptions)
expectedErr := status.Errorf(codes.InvalidArgument, "fsType(ext4) is not supported with protocol(nfs)")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("storeAccountKey must set as true in cross subscription", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
subscriptionIDField: "abc",
storeAccountKeyField: "false",
selectRandomMatchingAccountField: "true",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = &storage.AccountRepo{
Config: config.Config{},
}
expectedErr := status.Errorf(codes.InvalidArgument, "resourceGroup must be provided in cross subscription(abc)")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("invalid selectRandomMatchingAccount value", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
selectRandomMatchingAccountField: "invalid",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-selectRandomMatchingAccount-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = &storage.AccountRepo{
Config: config.Config{},
}
expectedErr := status.Errorf(codes.InvalidArgument, "invalid selectrandommatchingaccount: invalid in storage class")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("invalid getLatestAccountKey value", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
getLatestAccountKeyField: "invalid",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-getLatestAccountKey-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = &storage.AccountRepo{
Config: config.Config{},
}
expectedErr := status.Errorf(codes.InvalidArgument, "invalid getlatestaccountkey: invalid in storage class")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("storageAccount and matchTags conflict", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
storageAccountField: "abc",
matchTagsField: "true",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = &storage.AccountRepo{
Config: config.Config{},
}
expectedErr := status.Errorf(codes.InvalidArgument, "matchTags must set as false when storageAccount(abc) is provided")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("invalid privateEndpoint and subnetName combination", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
networkEndpointTypeField: "privateendpoint",
vnetLinkNameField: "vnetlink",
subnetNameField: "subnet1,subnet2",
}
req := &csi.CreateVolumeRequest{
Name: "invalid-privateEndpoint-and-subnetName-combination",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = &storage.AccountRepo{
Config: config.Config{},
}
expectedErr := status.Errorf(codes.InvalidArgument, "subnetName(subnet1,subnet2) can only contain one subnet for private endpoint")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Failed to update subnet service endpoints", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
protocolField: "nfs",
}
fakeCloud := &storage.AccountRepo{
Config: config.Config{
ResourceGroup: "rg",
Location: "loc",
VnetName: "fake-vnet",
SubnetName: "fake-subnet",
},
}
retErr := fmt.Errorf("the subnet does not exist")
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = fakeCloud
mockSubnetClient := mock_subnetclient.NewMockInterface(ctrl)
fakeCloud.NetworkClientFactory = mock_azclient.NewMockClientFactory(ctrl)
fakeCloud.NetworkClientFactory.(*mock_azclient.MockClientFactory).EXPECT().GetSubnetClient().Return(mockSubnetClient).AnyTimes()
mockSubnetClient.EXPECT().List(gomock.Any(), gomock.Any(), gomock.Any()).Return([]*armnetwork.Subnet{}, retErr).Times(1)
expectedErr := status.Errorf(codes.Internal, "update service endpoints failed with error: failed to list the subnets under rg rg vnet fake-vnet: the subnet does not exist")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Failed with storeAccountKey is not supported for account with shared access key disabled", func() {
ginkgo.It("should fail", func(ctx context.Context) {
allParam := map[string]string{
skuNameField: "premium",
storageAccountTypeField: "stoacctype",
locationField: "loc",
storageAccountField: "stoacc",
resourceGroupField: "rg",
shareNameField: "",
diskNameField: "diskname.vhd",
fsTypeField: "",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "default",
mountPermissionsField: "0755",
accountQuotaField: "1000",
allowSharedKeyAccessField: "false",
}
fakeCloud := &storage.AccountRepo{
Config: config.Config{
ResourceGroup: "rg",
Location: "loc",
VnetName: "fake-vnet",
SubnetName: "fake-subnet",
},
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-vol-cap-invalid",
CapacityRange: stdCapRange,
VolumeCapabilities: stdVolCap,
Parameters: allParam,
}
d.cloud = fakeCloud
expectedErr := status.Errorf(codes.InvalidArgument, "storeAccountKey is not supported for account with shared access key disabled")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("No valid key, check all params, with less than min premium volume", func() {
ginkgo.It("should fail", func(ctx context.Context) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := ""
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
skuNameField: "premium",
locationField: "loc",
storageAccountField: "",
resourceGroupField: "rg",
shareNameField: "",
diskNameField: "diskname.vhd",
fsTypeField: "",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "secretnamespace",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-no-valid-key-check-all-params",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockFileClient.EXPECT().Create(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
expectedErr := fmt.Errorf("no valid keys")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err.Error()).To(gomega.ContainSubstring(expectedErr.Error()))
})
})
ginkgo.When("management client", func() {
ginkgo.When("Get file share returns error", func() {
ginkgo.It("should fail", func(ctx context.Context) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location, Properties: &armstorage.AccountProperties{}},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-get-file-error",
VolumeCapabilities: stdVolCap,
CapacityRange: stdCapRange,
Parameters: nil,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockFileClient.EXPECT().Create(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, fmt.Errorf("test error")).AnyTimes()
expectedErr := status.Errorf(codes.Internal, "test error")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Create file share error tests", func() {
ginkgo.It("should fail", func(ctx context.Context) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
storageAccountTypeField: "premium",
locationField: "loc",
storageAccountField: "stoacc",
resourceGroupField: "rg",
shareNameField: "",
diskNameField: "diskname.vhd",
fsTypeField: "",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "secretnamespace",
disableDeleteRetentionPolicyField: "true",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-crete-file-error",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
expectedErr := status.Errorf(codes.Internal, "FileShareProperties or FileShareProperties.ShareQuota is nil")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("existing file share quota is smaller than request quota", func() {
ginkgo.It("should fail", func(ctx context.Context) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
storageAccountTypeField: "premium",
locationField: "loc",
storageAccountField: "stoacc",
resourceGroupField: "rg",
shareNameField: "",
diskNameField: "diskname.vhd",
fsTypeField: "",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "secretnamespace",
disableDeleteRetentionPolicyField: "true",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-crete-file-error",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: ptr.To(int32(1))}}, nil).AnyTimes()
expectedErr := status.Errorf(codes.AlreadyExists, "request file share(random-vol-name-crete-file-error) already exists, but its capacity 1 is smaller than 100")
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(expectedErr))
})
})
ginkgo.When("Create disk returns error", func() {
ginkgo.It("should fail", func(ctx context.Context) {
if runtime.GOOS == "windows" {
ginkgo.Skip("Skipping test on Windows")
}
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
skuNameField: "premium",
storageAccountTypeField: "stoacctype",
locationField: "loc",
storageAccountField: "stoacc",
resourceGroupField: "rg",
fsTypeField: "ext4",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "default",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-create-disk-error",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
driverOptions := DriverOptions{
NodeID: fakeNodeID,
DriverName: DefaultDriverName,
EnableVHDDiskFeature: true,
}
d := NewFakeDriverCustomOptions(driverOptions)
d.cloud = &storage.AccountRepo{}
d.cloud.ComputeClientFactory = computeClientFactory
d.kubeClient = fake.NewSimpleClientset()
tests := []struct {
desc string
fileSharename string
expectedErr error
}{
{
desc: "File share name empty",
fileSharename: "",
expectedErr: status.Error(codes.Internal, "failed to create VHD disk: NewSharedKeyCredential(stoacc) failed with error: decode account key: illegal base64 data at input byte 0"),
},
{
desc: "File share name provided",
fileSharename: "filesharename",
expectedErr: status.Error(codes.Internal, "failed to create VHD disk: NewSharedKeyCredential(stoacc) failed with error: decode account key: illegal base64 data at input byte 0"),
},
}
for _, test := range tests {
allParam[shareNameField] = test.fileSharename
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockFileClient.EXPECT().Create(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: &fakeShareQuota}}, nil).AnyTimes()
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).To(gomega.Equal(test.expectedErr))
}
})
})
ginkgo.When("Valid request", func() {
ginkgo.It("should fail", func(ctx context.Context) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
skuNameField: "premium",
storageAccountTypeField: "stoacctype",
locationField: "loc",
storageAccountField: "stoacc",
resourceGroupField: "rg",
shareNameField: "",
diskNameField: "diskname.vhd",
fsTypeField: "",
storeAccountKeyField: "storeaccountkey",
secretNamespaceField: "default",
mountPermissionsField: "0755",
accountQuotaField: "1000",
useDataPlaneAPIField: "oauth",
clientIDField: "client-id",
provisionedBandwidthField: "100",
provisionedIopsField: "800",
runtimeClassHandlerField: "runtime-handler",
createFolderIfNotExistField: "true",
confidentialContainerLabelField: "confidential-container-label",
mountWithManagedIdentityField: "true",
mountWithWITokenField: "false",
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-valid-request",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockFileClient.EXPECT().Create(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: &fakeShareQuota}}, nil).AnyTimes()
_, err := d.CreateVolume(ctx, req)
gomega.Expect(err).NotTo(gomega.HaveOccurred())
})
})
// Consolidate duplicate test scenarios
commonTests := func(ctx context.Context, encryptInTransit string, shouldSucceed bool) {
name := "baz"
SKU := "SKU"
kind := "StorageV2"
location := "centralus"
value := "foo bar"
accounts := []*armstorage.Account{
{Name: &name, SKU: &armstorage.SKU{Name: to.Ptr(armstorage.SKUName(SKU))}, Kind: to.Ptr(armstorage.Kind(kind)), Location: &location},
}
keys := []*armstorage.AccountKey{
{Value: &value},
}
allParam := map[string]string{
storageAccountField: "stoacc",
encryptInTransitField: encryptInTransit,
}
req := &csi.CreateVolumeRequest{
Name: "random-vol-name-valid-request",
VolumeCapabilities: stdVolCap,
CapacityRange: lessThanPremCapRange,
Parameters: allParam,
}
mockStorageAccountsClient := d.cloud.ComputeClientFactory.GetAccountClient().(*mock_accountclient.MockInterface)
mockFileClient.EXPECT().Create(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: nil}}, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().ListKeys(gomock.Any(), gomock.Any(), gomock.Any()).Return(keys, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().List(gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
mockFileClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(&armstorage.FileShare{FileShareProperties: &armstorage.FileShareProperties{ShareQuota: &fakeShareQuota}}, nil).AnyTimes()
_, err := d.CreateVolume(ctx, req)
if shouldSucceed {
gomega.Expect(err).NotTo(gomega.HaveOccurred())
} else {
expectedErr := status.Errorf(codes.InvalidArgument, "invalid %s: %s in storage class", encryptInTransitField, encryptInTransit)
gomega.Expect(err).To(gomega.Equal(expectedErr))
}
}
// Use the consolidated test function
ginkgo.When("encryptInTransit is true", func() {
ginkgo.It("should succeed", func(ctx context.Context) {
commonTests(ctx, "true", true)
})
})