Skip to content
This repository was archived by the owner on Feb 21, 2022. It is now read-only.

Commit 6367468

Browse files
paveldedikaexvir
authored andcommitted
fix(auditing): Do not display issues with a deleted kind
1 parent 91303e6 commit 6367468

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

zoo/auditing/views.py

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,14 +210,25 @@ def get_context_data(self, **kwargs):
210210
context["project_type"] = self.kwargs["project_type"]
211211
context["issues"] = defaultdict(list)
212212

213+
deleted_issues = []
214+
213215
if project.repository:
214-
for issue in project.repository.issues.filter(deleted=False).exclude(
215-
status__in=[
216-
models.Issue.Status.FIXED.value,
217-
models.Issue.Status.NOT_FOUND.value,
218-
models.Issue.Status.WONTFIX.value,
219-
]
216+
for issue in (
217+
project.repository.issues.filter(deleted=False)
218+
.exclude(
219+
status__in=[
220+
models.Issue.Status.FIXED.value,
221+
models.Issue.Status.NOT_FOUND.value,
222+
models.Issue.Status.WONTFIX.value,
223+
]
224+
)
225+
.filter(kind_key__in=KINDS) # filter out removed issue kinds
220226
):
227+
if issue.deleted:
228+
# deleting issues still present in KINDS but not relevant
229+
# for the repository anymore
230+
deleted_issues.append(issue)
231+
221232
context["issues"][issue.kind.category].append(issue)
222233

223234
# with defaultdict {{ issues.items }} would be empty, and we want consistent issue order anyway
@@ -226,7 +237,6 @@ def get_context_data(self, **kwargs):
226237
for key, value in sorted(context["issues"].items())
227238
)
228239

229-
deleted_issues = project.repository.issues.filter(deleted=True).all()
230240
if deleted_issues:
231241
unknown_ctg = "Deprecated Issues"
232242
context["issues"][unknown_ctg] = deleted_issues

0 commit comments

Comments
 (0)