test: stabilize runtime and plugin test workflow

Author: thisislvca

.github/workflows/test.yml

@@ -143,10 +143,6 @@ jobs:
 
       - run: bun install
 
-      - name: Start bundler
-        run: bun start &
-        working-directory: apps/example
-
       - uses: actions/cache@v4
         with:
           path: packages/react-native-device-activity/ios/TestHarness/Pods
@@ -174,5 +170,5 @@ jobs:
       - run: pod install
         working-directory: packages/react-native-device-activity/ios/TestHarness
 
-      - run: xcodebuild test -workspace reactnativedeviceactivityexample.xcworkspace -scheme Tests -destination "platform=iOS Simulator,OS=latest,name=iPhone 17" CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
+      - run: xcodebuild test -workspace reactnativedeviceactivityexample.xcworkspace -scheme Tests -destination "platform=iOS Simulator,OS=latest,name=iPhone 17"
         working-directory: packages/react-native-device-activity/ios/TestHarness

package.json

@@ -8,8 +8,9 @@
     "format:check": "node ./node_modules/prettier/bin/prettier.cjs --check .",
     "format:version": "node ./node_modules/prettier/bin/prettier.cjs --version && node -e \"console.log(require('./node_modules/prettier/package.json').version)\"",
     "lint": "eslint .",
+    "test": "cd packages/react-native-device-activity && bun run test",
     "swiftlint": "[ -x packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint ] || (echo 'SwiftLint pod binary missing. Run: cd packages/react-native-device-activity/ios/TestHarness && pod install' && exit 1); packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint lint --strict --config .swiftlint.yml",
-    "pre-push": "bun run typecheck && bun run lint && bun run swiftlint",
+    "pre-push": "bun run typecheck && bun run lint && bun run test && bun run swiftlint",
     "typecheck": "cd packages/react-native-device-activity && bun run typecheck && cd ../../apps/example && bun run typecheck",
     "prepare": "husky",
     "nail-workspace-dependency-versions": "bun run scripts/nail-workspace-dependency-versions.ts"

packages/react-native-device-activity/ios/Tests/IsShieldActiveTests.swift

@@ -8,6 +8,8 @@ import FamilyControls
 import ManagedSettings
 import Testing
 
+// NOTE: These assertions fail on simulator when xcodebuild is run with
+// CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO.
 @Suite(.serialized) struct IsShieldActiveTests {
 
   @Test func shieldIsNotActive() async throws {

packages/react-native-device-activity/jest.runtime.config.js

@@ -0,0 +1,14 @@
+module.exports = {
+  testEnvironment: "node",
+  clearMocks: true,
+  roots: ["<rootDir>/src"],
+  testRegex: ".*\\.test\\.ts$",
+  transform: {
+    "^.+\\.[jt]sx?$": [
+      "babel-jest",
+      {
+        configFile: require.resolve("expo-module-scripts/babel.config.cli.js"),
+      },
+    ],
+  },
+};

packages/react-native-device-activity/package.json

@@ -9,7 +9,8 @@
     "clean": "expo-module clean",
     "lint": "expo-module lint",
     "typecheck": "tsc --noEmit",
-    "test": "expo-module test",
+    "test": "bun run test:runtime && bun run test:plugin",
+    "test:runtime": "expo-module test --config ./jest.runtime.config.js",
     "test:plugin": "expo-module test plugin",
     "prepublishOnly": "expo-module prepublishOnly && tsc && cp ../../README.md ./README.md",
     "expo-module": "expo-module",

packages/react-native-device-activity/src/index.test.ts

@@ -1,24 +1,64 @@
-// todo: skipping for now
-
-describe("test", () => {
-  test("Should call stopMonitoring", () => {
-    const mockStopMonitoring = jest.fn();
-    jest.mock("./ReactNativeDeviceActivityModule", () => ({
-      stopMonitoring: mockStopMonitoring,
-    }));
-    const { stopMonitoring } = require("./");
-    stopMonitoring();
-    expect(mockStopMonitoring).toHaveBeenCalled();
+const mockNativeModule = {
+  stopMonitoring: jest.fn(),
+  startMonitoring: jest.fn(),
+};
+
+jest.mock("react-native", () => ({
+  Platform: {
+    OS: "ios",
+    select: (options: Record<string, unknown>) =>
+      options.ios ?? options.default,
+  },
+}));
+
+jest.mock("expo-modules-core", () => {
+  class MockEventEmitter {
+    addListener() {
+      return { remove: jest.fn() };
+    }
+
+    removeAllListeners() {}
+  }
+
+  return {
+    EventEmitter: MockEventEmitter,
+    EventSubscription: class {},
+  };
+});
+
+jest.mock("./ReactNativeDeviceActivityModule", () => ({
+  __esModule: true,
+  default: mockNativeModule,
+}));
+
+describe("index runtime wrapper", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    jest.resetModules();
   });
 
-  test("Should call startMonitoring", () => {
-    jest.resetAllMocks();
-    const mockStartMonitoring = jest.fn();
-    jest.mock("./ReactNativeDeviceActivityModule", () => ({
-      startMonitoring: mockStartMonitoring,
-    }));
-    const { startMonitoring } = require("./");
-    startMonitoring("test", {}, []);
-    expect(mockStartMonitoring).toHaveBeenCalled();
+  test("delegates stopMonitoring to native module", () => {
+    const { stopMonitoring } = require("./index");
+    const activities = ["activity-a"];
+
+    stopMonitoring(activities);
+
+    expect(mockNativeModule.stopMonitoring).toHaveBeenCalledWith(activities);
+  });
+
+  test("delegates startMonitoring to native module", async () => {
+    mockNativeModule.startMonitoring.mockResolvedValueOnce(undefined);
+    const { startMonitoring } = require("./index");
+
+    await startMonitoring(
+      "activity-a",
+      {
+        intervalStart: { hour: 0, minute: 0 },
+        intervalEnd: { hour: 23, minute: 59 },
+      },
+      [],
+    );
+
+    expect(mockNativeModule.startMonitoring).toHaveBeenCalled();
   });
 });