Skip to content

Commit 16ad4d8

Browse files
arc9693k8s-infra-cherrypick-robot
authored andcommitted
azurefile: add kata-cc-isolation node label check
1 parent 86a8958 commit 16ad4d8

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

pkg/azurefile/azurefile.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,28 +1286,28 @@ func (d *Driver) getFileShareClientForSub(subscriptionID string) (fileshareclien
12861286
return d.cloud.ComputeClientFactory.GetFileShareClientForSub(subscriptionID)
12871287
}
12881288

1289-
func getNodeInfoFromLabels(ctx context.Context, nodeID string, kubeClient clientset.Interface) (string, string, error) {
1289+
func getNodeInfoFromLabels(ctx context.Context, nodeID string, kubeClient clientset.Interface) (string, string, string, error) {
12901290
if kubeClient == nil || kubeClient.CoreV1() == nil {
1291-
return "", "", fmt.Errorf("kubeClient is nil")
1291+
return "", "", "", fmt.Errorf("kubeClient is nil")
12921292
}
12931293

12941294
node, err := kubeClient.CoreV1().Nodes().Get(ctx, nodeID, metav1.GetOptions{})
12951295
if err != nil {
1296-
return "", "", fmt.Errorf("get node(%s) failed with %v", nodeID, err)
1296+
return "", "", "", fmt.Errorf("get node(%s) failed with %v", nodeID, err)
12971297
}
12981298

12991299
if len(node.Labels) == 0 {
1300-
return "", "", fmt.Errorf("node(%s) label is empty", nodeID)
1300+
return "", "", "", fmt.Errorf("node(%s) label is empty", nodeID)
13011301
}
1302-
return node.Labels["kubernetes.azure.com/kata-mshv-vm-isolation"], node.Labels["katacontainers.io/kata-runtime"], nil
1302+
return node.Labels["kubernetes.azure.com/kata-cc-isolation"], node.Labels["kubernetes.azure.com/kata-mshv-vm-isolation"], node.Labels["katacontainers.io/kata-runtime"], nil
13031303
}
13041304

13051305
func isKataNode(ctx context.Context, nodeID string, kubeClient clientset.Interface) bool {
13061306
if nodeID == "" {
13071307
return false
13081308
}
13091309

1310-
kataVMIsolationLabel, kataRuntimeLabel, err := getNodeInfoFromLabels(ctx, nodeID, kubeClient)
1310+
kataCCIsolationLabel, kataVMIsolationLabel, kataRuntimeLabel, err := getNodeInfoFromLabels(ctx, nodeID, kubeClient)
13111311

13121312
if err != nil {
13131313
klog.Warningf("failed to get node info from labels: %v", err)
@@ -1316,5 +1316,5 @@ func isKataNode(ctx context.Context, nodeID string, kubeClient clientset.Interfa
13161316

13171317
klog.V(4).Infof("node(%s) labels: kataVMIsolationLabel(%s), kataRuntimeLabel(%s)", nodeID, kataVMIsolationLabel, kataRuntimeLabel)
13181318

1319-
return strings.EqualFold(kataVMIsolationLabel, "true") || strings.EqualFold(kataRuntimeLabel, "true")
1319+
return strings.EqualFold(kataCCIsolationLabel, "true") || strings.EqualFold(kataVMIsolationLabel, "true") || strings.EqualFold(kataRuntimeLabel, "true")
13201320
}

pkg/azurefile/azurefile_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1640,7 +1640,7 @@ func TestGetNodeInfoFromLabels(t *testing.T) {
16401640
nodeName string
16411641
labels map[string]string
16421642
setupClient bool
1643-
expectedVals [2]string
1643+
expectedVals [3]string
16441644
expectedErr error
16451645
}{
16461646
{
@@ -1667,10 +1667,11 @@ func TestGetNodeInfoFromLabels(t *testing.T) {
16671667
nodeName: "test-node",
16681668
setupClient: true,
16691669
labels: map[string]string{
1670+
"kubernetes.azure.com/kata-cc-isolation": "true",
16701671
"kubernetes.azure.com/kata-mshv-vm-isolation": "true",
16711672
"katacontainers.io/kata-runtime": "false",
16721673
},
1673-
expectedVals: [2]string{"true", "false"},
1674+
expectedVals: [3]string{"true", "true", "false"},
16741675
expectedErr: nil,
16751676
},
16761677
}
@@ -1695,14 +1696,15 @@ func TestGetNodeInfoFromLabels(t *testing.T) {
16951696
assert.NoError(t, err)
16961697
}
16971698

1698-
kataVMIsolation, kataRuntime, err := getNodeInfoFromLabels(ctx, tc.nodeName, clientset)
1699+
kataCCIsolation, kataVMIsolation, kataRuntime, err := getNodeInfoFromLabels(ctx, tc.nodeName, clientset)
16991700

17001701
if tc.expectedErr != nil {
17011702
assert.EqualError(t, err, tc.expectedErr.Error())
17021703
} else {
17031704
assert.NoError(t, err)
1704-
assert.Equal(t, tc.expectedVals[0], kataVMIsolation)
1705-
assert.Equal(t, tc.expectedVals[1], kataRuntime)
1705+
assert.Equal(t, tc.expectedVals[0], kataCCIsolation)
1706+
assert.Equal(t, tc.expectedVals[1], kataVMIsolation)
1707+
assert.Equal(t, tc.expectedVals[2], kataRuntime)
17061708
}
17071709
})
17081710
}

0 commit comments

Comments
 (0)