Skip to content

Potential buffer overrun in function init_send_receive_history #2

@npat-efault

Description

@npat-efault

In your code, in picocom.c, line 676, you should use "strcpy" instead of "strcat".
As you get "send_receive_history_file_path" from a "malloc", there is no guarantee that it will be zeroed-out.
This, or you should change "malloc" to "calloc".

https://github.com/jhandley/picocom/blob/master/picocom.c#L676

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions