test: Hold the auth state gates the fix left unpinned

Reverting two of the five gates to a truthiness check left the suite green,
so the bug they fix could come back unnoticed. The status read path was
covered only by a test whose cache is a MagicMock, which is truthy whatever
it holds and so cannot see the difference, and the RPC client's clear on a
failed authentication had no test at all. Both now use a real empty cache,
which is the state the bug needs.

Two tests in the gateway file said less than their names. The custom timeout
one passed no timeout and asserted the default, making it a copy of the test
above it; it now passes one and follows it to both requests. The auth error
one fed two answers to four gathered reads, so the last two died as
StopIteration and were swallowed as ordinary failures; it now answers all
four.

Author: jfmlima

packages/core/tests/unit/gateways/device/test_shelly_device_gateway.py

@@ -76,18 +76,18 @@ async def test_it_discovers_device_with_custom_timeout(
             side_effect=[(device_info, 0.2), (update_info, 0.05)]
         )
 
-        result = await gateway.discover_device("192.168.1.100")
+        result = await gateway.discover_device("192.168.1.100", timeout=2.5)
 
         assert result is not None
         assert mock_rpc_client.make_rpc_request.call_count == 2
         calls = mock_rpc_client.make_rpc_request.call_args_list
         assert calls[0] == (
             ("192.168.1.100", "Shelly.GetDeviceInfo"),
-            {"timeout": 10.0},
+            {"timeout": 2.5},
         )
         assert calls[1] == (
             ("192.168.1.100", "Shelly.CheckForUpdate"),
-            {"timeout": 10.0},
+            {"timeout": 2.5},
         )
 
     async def test_it_handles_device_discovery_failure(
@@ -374,6 +374,8 @@ async def test_it_propagates_auth_error_from_get_device_status(
             side_effect=[
                 ({"name": "Test", "model": "SAWD-0A1XX10EU1"}, 0.05),
                 DeviceAuthenticationError("192.168.1.100", "No credentials stored"),
+                ({"sys": {}}, 0.1),
+                ({"methods": []}, 0.05),
             ]
         )
 
@@ -401,6 +403,28 @@ async def test_it_marks_auth_required_while_the_cache_is_still_empty(
         assert result.auth_required is True
         assert auth_state_cache.requires_auth("192.168.1.100") is True
 
+    async def test_it_marks_auth_required_from_a_status_read_on_an_empty_cache(
+        self, mock_rpc_client, mock_legacy_gateway
+    ):
+        auth_state_cache = AuthStateCache()
+        gateway = ShellyDeviceGateway(
+            rpc_client=mock_rpc_client,
+            legacy_gateway=mock_legacy_gateway,
+            auth_state_cache=auth_state_cache,
+        )
+        mock_rpc_client.make_rpc_request = AsyncMock(
+            side_effect=[
+                ({"auth_en": True}, 0.05),
+                ({"components": [], "cfg_rev": 1, "total": 0}, 0.1),
+                ({"sys": {}}, 0.1),
+                ({"methods": []}, 0.05),
+            ]
+        )
+
+        await gateway.get_device_status("192.168.1.100")
+
+        assert auth_state_cache.requires_auth("192.168.1.100") is True
+
     async def test_it_marks_auth_required_before_a_later_read_can_fail(
         self, mock_rpc_client, mock_legacy_gateway
     ):

packages/core/tests/unit/gateways/network/test_async_shelly_rpc_client.py

@@ -9,6 +9,7 @@
     DeviceUnreachableError,
 )
 from core.gateways.network.async_shelly_rpc_client import AsyncShellyRPCClient
+from core.services.auth_state_cache import AuthStateCache
 
 
 class TestAsyncShellyRPCClient:
@@ -251,3 +252,31 @@ async def test_it_uses_default_timeout_when_none_provided(
         assert isinstance(timeout_arg, httpx.Timeout)
         assert timeout_arg.read == 3.0
         assert timeout_arg.connect == 2.0
+
+
+class TestAuthStateCacheGating:
+    """An empty AuthStateCache is falsy, so presence must decide these paths."""
+
+    async def test_it_clears_auth_state_while_the_cache_is_still_empty(self):
+        auth_state_cache = AuthStateCache()
+        client = AsyncShellyRPCClient(
+            session=AsyncMock(spec=httpx.AsyncClient),
+            auth_state_cache=auth_state_cache,
+        )
+
+        client._invalidate_auth_cache("192.168.1.100")
+
+        assert auth_state_cache.is_known("192.168.1.100") is True
+        assert auth_state_cache.requires_auth("192.168.1.100") is False
+
+    async def test_it_clears_auth_state_for_a_known_mac_while_the_cache_is_empty(self):
+        auth_state_cache = AuthStateCache()
+        client = AsyncShellyRPCClient(
+            session=AsyncMock(spec=httpx.AsyncClient),
+            auth_state_cache=auth_state_cache,
+        )
+        client._ip_to_mac["192.168.1.100"] = "AABBCCDDEEFF"
+
+        client._invalidate_auth_cache("192.168.1.100")
+
+        assert auth_state_cache.is_known("AABBCCDDEEFF") is True