Fix a test which improperly formulated file URIs

String-formatting in a test prepended `file://` to a path, which does not
produce a valid file URI on Windows.

Author: sirosen

tests/test_repository_pypi.py

@@ -429,7 +429,7 @@ def mock_get(*args, **kwargs):
     assert actual_data is None
 
 
-def test_name_collision(from_line, pypi_repository, make_package, make_sdist, tmpdir):
+def test_name_collision(from_line, pypi_repository, make_package, make_sdist, tmp_path):
     """
     Test to ensure we don't fail if there are multiple URL-based requirements
     ending with the same filename where later ones depend on earlier, e.g.
@@ -446,7 +446,7 @@ def test_name_collision(from_line, pypi_repository, make_package, make_sdist, tm
     }
 
     for pkg_name, pkg in packages.items():
-        pkg_path = tmpdir / pkg_name
+        pkg_path = tmp_path / pkg_name
 
         make_sdist(pkg, pkg_path, "--formats=zip")
 
@@ -455,17 +455,13 @@ def test_name_collision(from_line, pypi_repository, make_package, make_sdist, tm
             os.path.join(pkg_path, "main.zip"),
         )
 
-    name_collision_1 = "file://{dist_path}#egg=test_package_1".format(
-        dist_path=tmpdir / "test_package_1" / "main.zip"
-    )
-    ireq = from_line(name_collision_1)
+    dist_uri_1 = (tmp_path / "test_package_1" / "main.zip").as_uri()
+    ireq = from_line(f"{dist_uri_1}#egg=test_package_1")
     deps = pypi_repository.get_dependencies(ireq)
     assert len(deps) == 0
 
-    name_collision_2 = "file://{dist_path}#egg=test_package_2".format(
-        dist_path=tmpdir / "test_package_2" / "main.zip"
-    )
-    ireq = from_line(name_collision_2)
+    dist_uri_2 = (tmp_path / "test_package_2" / "main.zip").as_uri()
+    ireq = from_line(f"{dist_uri_2}#egg=test_package_2")
     deps = pypi_repository.get_dependencies(ireq)
     assert len(deps) == 1
     assert deps.pop().name == "test-package-1"