Add test to ensure OmniAuth can be called directly

Author: janko

lib/rodauth/features/omniauth_base.rb

@@ -108,7 +108,7 @@ def build_omniauth_app
       )
       builder.configure do |config|
         [:request_validation_phase, :before_request_phase, :before_callback_phase, :on_failure].each do |hook|
-          config.send(:"#{hook}=", -> (env) { env["rodauth.omniauth.instance"].send(:"omniauth_#{hook}") if env["rodauth.omniauth.instance"] })
+          config.send(:"#{hook}=", -> (env) { env["rodauth.omniauth.instance"]&.send(:"omniauth_#{hook}") })
         end
       end
       self.class.instance_variable_get(:@omniauth_providers).each do |(provider, *args)|

test/omniauth_base_test.rb

@@ -339,8 +339,6 @@
 
     page.driver.post "/auth/developer"
     assert_equal "Roda::RodaPlugins::RouteCsrf::InvalidToken: encoded token is not a string", page.html
-
-    OmniAuth.config.allowed_request_methods = %i[get post]
   end
 
   it "returns authorize URL when using JSON" do
@@ -509,4 +507,22 @@
     app.freeze
     assert app.rodauth.frozen?
   end
+
+  it "still allows calling OmniAuth directly" do
+    rodauth do
+      enable :omniauth_base
+    end
+    roda do |r|
+    end
+
+    builder = OmniAuth::Builder.new do |b|
+      b.use Rack::Session::Cookie, :secret => "a" * 64
+      b.provider :developer
+      b.run -> (env) { [404, {}, []] } # pass through
+    end
+    app = Rack::MockRequest.new(builder.to_app)
+    response = app.get "/auth/developer"
+    assert_equal 200, response.status
+    assert_includes response.body, "</form>"
+  end
 end

test/omniauth_test.rb

@@ -181,8 +181,6 @@
 
     visit "/auth/developer"
     assert_equal 404, page.status_code
-
-    OmniAuth.config.allowed_request_methods = %i[get post]
   end
 
   it "deletes omniauth identities when account is closed" do

test/test_helper.rb

@@ -54,9 +54,6 @@
 
 Sequel::Model.cache_anonymous_models = false
 
-OmniAuth.config.allowed_request_methods = %i[get post]
-OmniAuth.config.logger = Logger.new(nil)
-
 class Minitest::HooksSpec
   include Capybara::DSL
 
@@ -113,12 +110,18 @@ def logout
     click_on "Logout"
   end
 
+  before do
+    OmniAuth.config.allowed_request_methods = %i[get post]
+    OmniAuth.config.logger = Logger.new(nil)
+  end
+
   around do |&block|
     DB.transaction(rollback: :always, auto_savepoint: true) { super(&block) }
   end
 
   after do
     Capybara.reset_sessions!
+    OmniAuth.config.send(:initialize) # reset OmniAuth configuration
   end
 end