Clean up llm_interface

* Use generic llm class for all requests
* Add model temperature and system prompt settings
* Make save button more prominent on summarizer UI
* Tidy up some files

Author: GovernmentPlates

ai_summary/indico_ai_summary/client/components/ActionButtons.jsx

@@ -14,6 +14,8 @@ import '../styles/ind_summarize_button.module.scss';
 export default function ActionButtons({loading, error, summaryHtml, saving, onSave, onRetry}) {
 
     const [isCopied, setIsCopied] = useState(false);
+    const [showSavedIcon, setShowSavedIcon] = useState(false);
+    const [prevSaving, setPrevSaving] = useState(false);
 
     useEffect(() => {
         if (isCopied) {
@@ -22,19 +24,19 @@ export default function ActionButtons({loading, error, summaryHtml, saving, onSa
         }
     }, [isCopied]);
 
+    useEffect(() => {
+        if (prevSaving && !saving) {
+            setShowSavedIcon(true);
+            const timer = setTimeout(() => setShowSavedIcon(false), 2000);
+            return () => clearTimeout(timer);
+        }
+        setPrevSaving(saving);
+    }, [saving, prevSaving]);
+
     if (!loading) {
         return (
+            <div styleName="action-buttons-container">
               <ButtonGroup basic>
-                {summaryHtml && !error && (
-                  <Popup trigger={
-                    <Button icon onClick={onSave} disabled={saving}>
-                      {saving ? <Icon name="spinner" loading /> : <Icon name="save" />}
-                    </Button>
-                  }
-                    content={saving ? Translate.string('Saving summary...') : Translate.string('Save the generated summary to the meeting minutes')}
-                    position="top center"
-                  />
-                )}
                 {summaryHtml && !error && (
                   <Popup trigger={
                     <Button
@@ -63,6 +65,30 @@ export default function ActionButtons({loading, error, summaryHtml, saving, onSa
                   position="top center"
                 />
               </ButtonGroup>
+
+              {summaryHtml && !error && (
+                <Popup trigger={
+                  <Button primary={!showSavedIcon} basic={showSavedIcon} icon onClick={onSave} disabled={saving} styleName="save-button">
+                    {saving ? (
+                      <Icon name="spinner" loading />
+                    ) : showSavedIcon ? (
+                      <Icon name="check" color="green" />
+                    ) : (
+                      <Icon name="save" />
+                    )}
+                  </Button>
+                }
+                  content={
+                    saving
+                      ? Translate.string('Saving summary...')
+                      : showSavedIcon
+                        ? Translate.string('Saved!')
+                        : Translate.string('Save the generated summary to the meeting minutes')
+                  }
+                  position="top center"
+                />
+              )}
+            </div>
           );
       }
 

ai_summary/indico_ai_summary/client/components/SummaryPreview.jsx

@@ -27,7 +27,7 @@ export default function SummaryPreview({loading, error, summaryHtml, saving, onS
   }, [streamResponse, summaryHtml, error]);
 
   const scrollBarStyle = loading && !error ? "preview-card-wrapper scrollbar-hidden" : "preview-card-wrapper";
-  const displayedHtml = summaryHtml ? (error ? summaryHtml.substring(0, 1200) : summaryHtml) : null;
+  const displayedHtml = summaryHtml ? (error ? summaryHtml.substring(0, 1000) : summaryHtml) : null;
 
   if (!loading && !error && !summaryHtml) {
     return (

ai_summary/indico_ai_summary/client/components/ind_summarize_button.jsx

@@ -119,7 +119,7 @@ function SummarizeButton({categoryId, eventId, storedPrompts, streamResponse, ll
       // save combined notes(or previous summary) + summary back to Indico
       await saveSummaryToEvent(eventId, updatedHtml, noteData.id);
     } catch (e) {
-      setError(`Error during saving summary: ${handleAxiosError(e)}`);
+      setError(`Error during saving summary: ${handleAxiosError(e)}.`);
     } finally {
       setSaving(false);
     }

ai_summary/indico_ai_summary/client/services/summarize.js

@@ -74,7 +74,7 @@ export function streamSummary(eventId, prompt, {onChunk, onDone, onError} = {})
     }
     // Otherwise, we were in the middle of streaming and lost connection
     if (onError) {
-      onError('Connection lost while streaming summary.');
+      onError('Connection lost whilst streaming summary.');
     }
   };
 

ai_summary/indico_ai_summary/client/styles/ind_summarize_button.module.scss

@@ -161,3 +161,13 @@
     color: $dark-gray;
   }
 }
+
+.action-buttons-container {
+  display: flex;
+  align-items: baseline;
+  gap: 0;
+
+  .save-button {
+    margin-left: 10px !important;
+  }
+}

ai_summary/indico_ai_summary/client/utils/prompts.js

@@ -5,7 +5,7 @@
 # them and/or modify them under the terms of the MIT License;
 # see the LICENSE file for more details.
 
-from flask import jsonify, Response, stream_with_context
+from flask import Response, jsonify, stream_with_context
 from flask_pluginengine import current_plugin
 from webargs import fields
 from webargs.flaskparser import use_kwargs
@@ -16,11 +16,11 @@
 from indico.modules.events.management.controllers.base import RHManageEventBase
 from indico.modules.events.notes.util import get_scheduled_notes
 
+from indico_ai_summary.llm_interface import LLMInterface
 from indico_ai_summary.models.prompt import Prompt
 from indico_ai_summary.schemas import PromptSchema
-from indico_ai_summary.utils import chunk_text, convert_markup, MarkupMode, generate_chunk_stream
+from indico_ai_summary.utils import MarkupMode, chunk_text, convert_markup, generate_chunk_stream
 from indico_ai_summary.views import WPCategoryManagePrompts
-from indico_ai_summary.llm_interface import LLMInterface
 
 
 CATEGORY_SIDEMENU_ITEM = 'plugin_ai_summary_prompts'
@@ -78,7 +78,9 @@ def _process(self, prompt):
                 host=current_plugin.settings.get('llm_host_name'),
                 url=current_plugin.settings.get('llm_provider_url'),
                 auth_token=current_plugin.settings.get('llm_auth_token'),
-                max_tokens=current_plugin.settings.get('llm_max_tokens')
+                max_tokens=current_plugin.settings.get('llm_max_tokens'),
+                temperature=current_plugin.settings.get('llm_temperature'),
+                system_prompt=current_plugin.settings.get('llm_system_prompt')
             )
 
         if current_plugin.settings.get('llm_stream_response'):
@@ -87,7 +89,7 @@ def _process(self, prompt):
                 content_type='text/event-stream',
                 headers={
                     'Cache-Control': 'no-cache',
-                    'X-Accel-Buffering': 'no'
+                    'X-Accel-Buffering': 'no'  # Disable buffering for nginx
                 }
             )