Skip to content

Commit dd96df3

Browse files
nvidmarguusdk
authored andcommitted
Send the correct reason when offer is canceled or a timeout occurs
1 parent 7d2b40b commit dd96df3

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/java/org/jivesoftware/xmpp/workgroup/Offer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public void waitForResolution() {
221221
Log.debug("Accepted or not: send a revocation to all pending sessions.");
222222
try {
223223
for (AgentSession session : pendingSessions) {
224-
request.sendRevoke(session, queue);
224+
request.sendRevoke(session, queue, "The offer has timed out");
225225

226226
if (!isAccepted()) {
227227
Log.debug("Not accepted. Rejecting...");
@@ -240,10 +240,10 @@ public void cancel() {
240240
// Handle when customer cancels.
241241
if (!pendingSessions.isEmpty() || !acceptedSessions.isEmpty()) {
242242
for (AgentSession session : pendingSessions) {
243-
request.sendRevoke(session, queue);
243+
request.sendRevoke(session, queue, "User canceled");
244244
}
245245
for (AgentSession session : acceptedSessions) {
246-
request.sendRevoke(session, queue);
246+
request.sendRevoke(session, queue, "User canceled");
247247
}
248248
pendingSessions.clear();
249249
acceptedSessions.clear();

src/java/org/jivesoftware/xmpp/workgroup/dispatcher/OpportunisticDispatcher.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,15 @@ protected void sendToAgent(final Offer offer, final Instant timeout, AgentSessio
8282
// Create the room and send the invitations
8383
offer.invite(selectedAgent);
8484

85-
// Notify the other agents tat accepted that the offer process has finished. Other pending sessions will
85+
// Notify the other agents that accepted that the offer process has finished. Other pending sessions will
8686
// already have been notified.
8787
for (AgentSession offeredAgent : offeredAgents) {
8888
offeredAgent.removeOffer(offer);
8989
if (offeredAgent.equals(selectedAgent)) {
9090
continue;
9191
}
9292
Log.debug("Offer for request: {} REVOKING from agent that was also offered this request: {}", offer.getRequest(), offeredAgent.getJID());
93-
offer.getRequest().sendRevoke(offeredAgent, queue);
93+
offer.getRequest().sendRevoke(offeredAgent, queue, "The offer has timed out");
9494
}
9595

9696
if (offer.getRequest() instanceof UserRequest) {

src/java/org/jivesoftware/xmpp/workgroup/request/Request.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public boolean sendOffer(AgentSession session, RequestQueue queue) {
254254
* @param session the agent session that will get the revoke.
255255
* @param queue queue that is sending the offer.
256256
*/
257-
public void sendRevoke(AgentSession session, RequestQueue queue) {
257+
public void sendRevoke(AgentSession session, RequestQueue queue, String reason) {
258258
IQ agentRevoke = new IQ();
259259
agentRevoke.setFrom(queue.getWorkgroup().getJID());
260260
agentRevoke.setTo(session.getJID());
@@ -263,7 +263,7 @@ public void sendRevoke(AgentSession session, RequestQueue queue) {
263263
Element revoke = agentRevoke.setChildElement("offer-revoke", "http://jabber.org/protocol/workgroup");
264264
revoke.addAttribute("id", requestID);
265265
revoke.addAttribute("jid", getUserJID().toString());
266-
revoke.addElement("reason").setText("The offer has timed out");
266+
revoke.addElement("reason").setText(reason);
267267
revoke.add(getSessionElement());
268268
addRevokeContent(revoke);
269269

0 commit comments

Comments
 (0)