fix(pnpm-store): 🐛 fix silent failures in guard script ownership handling

Three bugs in the postCreateCommand guard:
- stat failure (NFS, overlay FS) returned empty store_owner, silently skipping
  chown and leaving the store root-owned with no diagnostic
- sudo absent: the chown if-block was skipped entirely with no warning, causing
  pnpm EACCES on first write with nothing in the logs
- sudo chown used 2>/dev/null || true, swallowing failures and printing a false
  success checkmark regardless of outcome

Fix: treat stat failure as "unknown" (attempt chown anyway), split the sudo
check to emit a warning when sudo is absent, and surface chown failures instead
of swallowing them.

Also add || true to the build-time mkdir -p to prevent aborting the image build
on unusual filesystems where root cannot create /workspaces.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: baxyz

src/pnpm-store/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
   "id": "pnpm-store",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "name": "pnpm Store (shared)",
   "description": "Shares a single pnpm content-addressable store across every repo and across rebuilds via a Docker named volume, so no stray .pnpm-store folders pollute your repos. Zero-config and autonomous: the volume is created automatically, with no host directory to pre-create.",
   "documentationURL": "https://github.com/helpers4/devcontainer/tree/main/src/pnpm-store",

src/pnpm-store/install.sh

@@ -82,7 +82,7 @@ echo "  ✅ Wrote store-dir to ${NPMRC}"
 # pnpm cannot create the store directory as a non-root user.
 # The named volume declared in devcontainer-feature.json shadows this directory
 # at container start — that's intentional.
-mkdir -p "${STORE_DIR}"
+mkdir -p "${STORE_DIR}" || true
 if [ "${USERNAME}" != "root" ]; then
     chown "${USERNAME}:${USER_GROUP}" "${STORE_DIR}" 2>/dev/null || true
 fi
@@ -121,9 +121,17 @@ fi
 # Named volumes are created root-owned; hand the store to the current user so
 # pnpm can write to it. Only chown when needed (recursive chown is expensive on
 # a populated store shared across rebuilds).
-store_owner="$(stat -c '%u' "${STORE_DIR}" 2>/dev/null || echo '')"
-if [ -n "${store_owner}" ] && [ "${store_owner}" != "$(id -u)" ] && command -v sudo >/dev/null 2>&1; then
-    sudo chown -R "$(id -u):$(id -g)" "${STORE_DIR}" 2>/dev/null || true
+# stat failure (NFS root-squash, overlay FS) is treated as "unknown" — attempt
+# chown anyway rather than silently skipping it.
+store_owner="$(stat -c '%u' "${STORE_DIR}" 2>/dev/null || echo 'unknown')"
+if [ "${store_owner}" != "$(id -u)" ]; then
+    if command -v sudo >/dev/null 2>&1; then
+        if ! sudo chown -R "$(id -u):$(id -g)" "${STORE_DIR}"; then
+            echo "⚠️  pnpm-store: chown failed — pnpm may not be able to write to the store"
+        fi
+    else
+        echo "⚠️  pnpm-store: store is owned by uid ${store_owner} and sudo is unavailable; pnpm writes will fail (EACCES)"
+    fi
 fi
 
 # Confirm pnpm picked up the configured store, when available.