Fix e2e: disable X access control on Xvfb, improve test diagnostics

Xvfb started as root denied xdotool connections from pi user.
Add -ac flag to disable X access control so any local user can
connect. Also add -L (follow redirects) to lighttpd curl checks
and improve diagnostic output for both failing tests.

Author: guysoft

testing/hooks/post-boot.sh

@@ -8,7 +8,7 @@ echo "Installing Xvfb and x11-apps..."
 $SSH_CMD "sudo apt-get update -qq && sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -qq xvfb x11-apps 2>&1 | tail -5"
 
 echo "Starting Xvfb virtual display..."
-$SSH_CMD "sudo nohup Xvfb :0 -screen 0 1280x720x24 > /tmp/xvfb.log 2>&1 < /dev/null &"
+$SSH_CMD "sudo nohup Xvfb :0 -screen 0 1280x720x24 -ac > /tmp/xvfb.log 2>&1 < /dev/null &"
 sleep 3
 
 echo "Verifying Xvfb is running..."

testing/tests/test_chromium.sh

@@ -42,7 +42,18 @@ if [ -n "$ARTIFACTS_DIR" ]; then
 fi
 
 if [ -z "$WINDOW_TITLE" ]; then
-    echo "  FAIL: No visible window on X display (display pipeline not working)"
+    echo "  No windows found with --onlyvisible, trying without visibility filter..."
+    WINDOW_TITLE=$($SSH_CMD "DISPLAY=:0 xdotool search --name . getwindowname 2>&1 || true" 2>/dev/null)
+    if [ -n "$ARTIFACTS_DIR" ]; then
+        echo "$WINDOW_TITLE" > "$ARTIFACTS_DIR/window-title.txt" 2>/dev/null || true
+    fi
+fi
+
+if [ -z "$WINDOW_TITLE" ]; then
+    echo "  Diagnosing X display access..."
+    $SSH_CMD "DISPLAY=:0 xdpyinfo 2>&1 | head -5 || echo 'xdpyinfo failed'" 2>/dev/null || true
+    $SSH_CMD "DISPLAY=:0 xdotool search --name . 2>&1 || echo 'xdotool search failed'" 2>/dev/null || true
+    echo "  FAIL: No window on X display (display pipeline not working)"
     exit 1
 fi
 

testing/tests/test_lighttpd.sh

@@ -15,22 +15,31 @@ DASHBOARD_URL="http://localhost/FullPageDashboard"
 
 LIGHTTPD_READY=0
 for i in $(seq 1 60); do
-    HTTP_CODE=$($SSH_CMD "curl -s -o /dev/null -w '%{http_code}' '$DASHBOARD_URL'" 2>/dev/null || echo "000")
+    HTTP_CODE=$($SSH_CMD "curl -sL -o /dev/null -w '%{http_code}' '$DASHBOARD_URL'" 2>/dev/null || echo "000")
     if [ "$HTTP_CODE" = "200" ]; then
         LIGHTTPD_READY=1
         break
     fi
-    printf "."
+    if [ "$((i % 12))" -eq 0 ]; then
+        echo " (HTTP $HTTP_CODE after ${i}x5s)"
+        $SSH_CMD "systemctl is-active lighttpd || true" 2>/dev/null || true
+        $SSH_CMD "curl -sL -o /dev/null -w 'root=%{http_code}' http://localhost/ || true" 2>/dev/null || true
+        echo ""
+    else
+        printf "."
+    fi
     sleep 5
 done
 echo ""
 
 if [ "$LIGHTTPD_READY" -eq 0 ]; then
-    echo "  FAIL: FullPageDashboard did not return HTTP 200 within 300s"
+    echo "  FAIL: FullPageDashboard did not return HTTP 200 within 300s (last code: $HTTP_CODE)"
+    $SSH_CMD "curl -sLI '$DASHBOARD_URL' 2>/dev/null | head -10" 2>/dev/null || true
+    $SSH_CMD "ls -la /var/www/html/FullPageDashboard/ 2>/dev/null || echo 'FullPageDashboard dir not found'" 2>/dev/null || true
     exit 1
 fi
 
-BODY=$($SSH_CMD "curl -s '$DASHBOARD_URL'" 2>/dev/null)
+BODY=$($SSH_CMD "curl -sL '$DASHBOARD_URL'" 2>/dev/null)
 
 if [ -n "$ARTIFACTS_DIR" ]; then
     echo "$BODY" > "$ARTIFACTS_DIR/lighttpd-index.html" 2>/dev/null || true