A year or two ago, with #208 a change was incorporated to enforce more strict naming rules. We often use FQDNs as tokens, eg for host/network definitions. Since this change that yields a large amount of warnings.
Would it be acceptable to also permit dots in token names? I haven't seen any problems yet when I locally change the token_re in L134 in naming.py, but maybe there's a downside to this that I don't understand yet.
[1]
|
self.token_re = re.compile(r'(^[-_A-Z0-9]+$)', re.IGNORECASE) |
A year or two ago, with #208 a change was incorporated to enforce more strict naming rules. We often use FQDNs as tokens, eg for host/network definitions. Since this change that yields a large amount of warnings.
Would it be acceptable to also permit dots in token names? I haven't seen any problems yet when I locally change the token_re in L134 in naming.py, but maybe there's a downside to this that I don't understand yet.
[1]
capirca/capirca/lib/naming.py
Line 134 in 4207b88