Skip to content

Commit 4848127

Browse files
authored
remove skip in TestBindCgoPackage & fix CI matrix (#388)
* remove skip condition for Go 1.23 in TestBindCgoPackage * remove skip condition for Go 1.23 in TestBindCgoPackage * update Go version matrix in CI configuration
1 parent c91ad4c commit 4848127

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
strategy:
2323
fail-fast: false
2424
matrix:
25-
go-version: [1.25.x, 1.24.x, 1.22.x, 1.21.x]
25+
go-version: [1.25.x, 1.24.x, 1.23.x, 1.22.x, 1.21.x]
2626
platform: [ubuntu-latest, windows-latest]
2727
#platform: [ubuntu-latest, macos-latest, windows-latest]
2828
runs-on: ${{ matrix.platform }}

main_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"os/exec"
1313
"path/filepath"
1414
"reflect"
15-
"runtime"
1615
"sort"
1716
"strings"
1817
"testing"
@@ -546,11 +545,6 @@ OK
546545
}
547546

548547
func TestBindCgoPackage(t *testing.T) {
549-
// Skip for some Go versions due to CGO issue
550-
// See: https://github.com/go-python/gopy/issues/370
551-
if strings.HasPrefix(runtime.Version(), "go1.23") {
552-
t.Skip("Skipping due to CGO issue (see https://github.com/go-python/gopy/issues/370)")
553-
}
554548
// t.Parallel()
555549
path := "_examples/cgo"
556550
testPkg(t, pkg{

0 commit comments

Comments
 (0)