test(actions): add tests for deployment environments

Author: alexosumi

models/actions/environment_test.go

@@ -0,0 +1,173 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package actions
+
+import (
+	"testing"
+
+	"gitea.dev/models/db"
+	"gitea.dev/models/unittest"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestEnvironmentMatchesBranch(t *testing.T) {
+	tests := []struct {
+		name              string
+		protectedBranches string
+		ref               string
+		want              bool
+	}{
+		{
+			name:              "empty policy allows everything",
+			protectedBranches: "",
+			ref:               "refs/heads/feature",
+			want:              true,
+		},
+		{
+			name:              "exact match",
+			protectedBranches: "main",
+			ref:               "refs/heads/main",
+			want:              true,
+		},
+		{
+			name:              "no match",
+			protectedBranches: "main",
+			ref:               "refs/heads/develop",
+			want:              false,
+		},
+		{
+			name:              "glob wildcard matches",
+			protectedBranches: "release/*",
+			ref:               "refs/heads/release/1.0",
+			want:              true,
+		},
+		{
+			name:              "glob wildcard no match",
+			protectedBranches: "release/*",
+			ref:               "refs/heads/main",
+			want:              false,
+		},
+		{
+			name:              "multiple patterns comma-separated, first matches",
+			protectedBranches: "main, staging",
+			ref:               "refs/heads/main",
+			want:              true,
+		},
+		{
+			name:              "multiple patterns comma-separated, second matches",
+			protectedBranches: "main, staging",
+			ref:               "refs/heads/staging",
+			want:              true,
+		},
+		{
+			name:              "multiple patterns, none match",
+			protectedBranches: "main, staging",
+			ref:               "refs/heads/feature/x",
+			want:              false,
+		},
+		{
+			name:              "glob and exact combo",
+			protectedBranches: "main, release/*",
+			ref:               "refs/heads/release/2.0",
+			want:              true,
+		},
+		{
+			name:              "ref without refs/heads/ prefix",
+			protectedBranches: "main",
+			ref:               "main",
+			want:              true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			env := &ActionEnvironment{ProtectedBranches: tt.protectedBranches}
+			assert.Equal(t, tt.want, env.MatchesBranch(tt.ref))
+		})
+	}
+}
+
+func TestEnvironmentCRUD(t *testing.T) {
+	require.NoError(t, unittest.PrepareTestDatabase())
+	ctx := t.Context()
+
+	const repoID int64 = 4
+
+	t.Run("Insert and Get", func(t *testing.T) {
+		env, err := InsertEnvironment(ctx, repoID, "production", "main")
+		require.NoError(t, err)
+		assert.Positive(t, env.ID)
+		assert.Equal(t, "production", env.Name)
+		assert.Equal(t, "main", env.ProtectedBranches)
+
+		got, err := GetEnvironmentByRepoAndName(ctx, repoID, "production")
+		require.NoError(t, err)
+		assert.Equal(t, env.ID, got.ID)
+
+		gotByID, err := GetEnvironmentByID(ctx, env.ID)
+		require.NoError(t, err)
+		assert.Equal(t, "production", gotByID.Name)
+	})
+
+	t.Run("Update", func(t *testing.T) {
+		env, err := InsertEnvironment(ctx, repoID, "staging", "develop")
+		require.NoError(t, err)
+
+		env.ProtectedBranches = "staging,develop"
+		require.NoError(t, UpdateEnvironment(ctx, env))
+
+		got, err := GetEnvironmentByID(ctx, env.ID)
+		require.NoError(t, err)
+		assert.Equal(t, "staging,develop", got.ProtectedBranches)
+	})
+
+	t.Run("Delete cascades secrets and variables", func(t *testing.T) {
+		env, err := InsertEnvironment(ctx, repoID, "preview", "")
+		require.NoError(t, err)
+
+		// insert a secret and a variable scoped to the env
+		secret := &ActionEnvironmentSecret{
+			RepoID:        repoID,
+			EnvironmentID: env.ID,
+			Name:          "TOKEN",
+			Data:          "encrypted",
+		}
+		require.NoError(t, db.Insert(ctx, secret))
+		variable := &ActionEnvironmentVariable{
+			RepoID:        repoID,
+			EnvironmentID: env.ID,
+			Name:          "APP_URL",
+			Data:          "https://preview.example.com",
+		}
+		require.NoError(t, db.Insert(ctx, variable))
+
+		require.NoError(t, DeleteEnvironment(ctx, repoID, env.ID))
+
+		// environment should be gone
+		_, err = GetEnvironmentByID(ctx, env.ID)
+		require.ErrorIs(t, err, ErrEnvironmentNotFound{})
+
+		// secrets and variables should be cascaded
+		secrets, err := db.Find[ActionEnvironmentSecret](ctx, FindEnvSecretsOptions{
+			RepoID:        repoID,
+			EnvironmentID: env.ID,
+		})
+		require.NoError(t, err)
+		assert.Empty(t, secrets)
+
+		vars, err := db.Find[ActionEnvironmentVariable](ctx, FindEnvVariablesOptions{
+			RepoID:        repoID,
+			EnvironmentID: env.ID,
+		})
+		require.NoError(t, err)
+		assert.Empty(t, vars)
+	})
+
+	t.Run("NotFound error for unknown env", func(t *testing.T) {
+		_, err := GetEnvironmentByRepoAndName(ctx, repoID, "nonexistent")
+		require.ErrorIs(t, err, ErrEnvironmentNotFound{Name: "nonexistent"})
+	})
+}

modules/actions/jobparser/environment_test.go

@@ -0,0 +1,51 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package jobparser
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestDeploymentEnvironmentName(t *testing.T) {
+	tests := []struct {
+		name    string
+		yaml    string
+		wantEnv string
+	}{
+		{
+			name:    "no environment key",
+			yaml:    "on: push\njobs:\n  test:\n    runs-on: ubuntu-latest\n    steps:\n      - run: echo hi\n",
+			wantEnv: "",
+		},
+		{
+			name:    "scalar string environment",
+			yaml:    "on: push\njobs:\n  deploy:\n    runs-on: ubuntu-latest\n    environment: production\n    steps:\n      - run: echo hi\n",
+			wantEnv: "production",
+		},
+		{
+			name:    "object environment with name",
+			yaml:    "on: push\njobs:\n  deploy:\n    runs-on: ubuntu-latest\n    environment:\n      name: staging\n      url: https://staging.example.com\n    steps:\n      - run: echo hi\n",
+			wantEnv: "staging",
+		},
+		{
+			name:    "object environment name only",
+			yaml:    "on: push\njobs:\n  deploy:\n    runs-on: ubuntu-latest\n    environment:\n      name: preview\n    steps:\n      - run: echo hi\n",
+			wantEnv: "preview",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			workflows, err := Parse([]byte(tt.yaml))
+			require.NoError(t, err)
+			require.Len(t, workflows, 1)
+			_, job := workflows[0].Job()
+			require.NotNil(t, job)
+			assert.Equal(t, tt.wantEnv, job.DeploymentEnvironmentName())
+		})
+	}
+}