You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GitComet is a Git client written in Rust that started from frustration with existing tools on huge codebases like Chromium. After no existing alternative was found that matched a familiar user interface and could stay responsive and functional when browsing large repositories and file diffs GitComet was born. This PR adds the required metadata file and screenshots for a listing to git-scm.com.
I went through the source code and it looks solid overall. No telemetry, no license enforcement, and the input sanitization is generally careful (the clone URL validation rejects ext:: and http, and open_url is restricted to http/https/mailto).
A few things I noticed: there is an automatic update check on startup that contacts api.github.com (in crates/gitcomet-ui-gpui/src/view/update_check.rs). It can be disabled with GITCOMET_NO_UPDATE_CHECK, but it is on by default. Not telemetry, but worth being aware of.
Credentials (SSH passphrases, tokens) are passed to child Git processes via environment variables rather than stdin or a credential helper. That is visible to same-user processes via /proc/<pid>/environ on Linux, though I did not find any disk persistence of secrets.
The unsafe_code = "forbid" workspace lint is a nice touch, but it does not apply uniformly -- gitcomet-tree-sitter-alloc and the excluded win32-window-utils crate both contain unsafe blocks. The unsafe code there is narrow and understandable (allocator hooks, Win32 FFI), but the claim is not quite absolute.
On the YAML: the price field says "Free", but the website advertises a paid Professional tier at EUR 20. Other entries that have a freemium model reflect that in the price field. Might want to update this for accuracy. Also, the license field says "AGPL-3.0 license" -- on git-scm.com, existing entries use shorter forms like "MIT" or "GPLv2". Maybe just "AGPL-3.0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
GitComet is a Git client written in Rust that started from frustration with existing tools on huge codebases like Chromium. After no existing alternative was found that matched a familiar user interface and could stay responsive and functional when browsing large repositories and file diffs GitComet was born. This PR adds the required metadata file and screenshots for a listing to git-scm.com.