Fix types on states

Author: sebastienfilion

library/component.d.ts

@@ -30,21 +30,23 @@ export declare enum Callbacks {
   "disconnectedCallback",
 }
 
+type ValueOf<T> = T[keyof T];
+
 export function factorizeComponent<
-  S extends State,
   E extends CustomElement = CustomElement,
+  S extends State,
 >(
-  render: (element: E, state: State) => void,
-  state: State,
+  render: (element: E, state: S) => void,
+  state: S,
   ...fs: Array<HOF<E, S>>
 ): Constructor<E>;
 
 export function useAttributes<E extends CustomElement, S extends State>(
-  validateAttribute: <X>(
-    attributes: { name: string; oldValue: X; value: X },
+  validateAttribute: <X extends ValueOf<S>>(
+    attributes: { name: keyof S; oldValue: X; value: X },
     element?: E,
     state?: S,
-  ) => S | boolean,
+  ) => Partial<S> | boolean,
   map?: { [K in keyof S]: (x: string) => S[K] },
 ): HOF<E, S>;
 
@@ -71,5 +73,5 @@ export function useShadow<E extends CustomElement, S extends State>(
 
 export function useTemplate<E extends CustomElement, S extends State>(
   getTemplate: () => HTMLTemplateElement,
-  map: { [k: string]: (e: E) => CustomElement },
+  map?: { [k: string]: (e: E) => CustomElement },
 ): HOF<E, S>;

library/testing.d.ts

@@ -1,13 +1,16 @@
 import { Constructor, CustomElement } from "./component.d.ts";
 
-type ArgumentTypes<F extends (...xs: Array<unknown>) => unknown> = F extends (...args: infer A) => unknown ? A
+type ArgumentTypes<F extends (...xs: Array<unknown>) => unknown> = F extends
+  (...args: infer A) => unknown ? A
   : never;
 
 export function constructComponent<E extends CustomElement>(
   C: Constructor<E>,
 ): E;
 
-export function factorizeSpy<F extends (...xs: Array<unknown>) => unknown>(f?: F): [
+export function factorizeSpy<F extends (...xs: Array<unknown>) => unknown>(
+  f?: F,
+): [
   F,
   {
     (

library/utilities.d.ts

@@ -31,6 +31,8 @@ export function maybeCall<X, Y, E extends HTMLElement, XS extends Array<X>>(
   ...xs: XS
 ): Promise<Y | false>;
 
+export function noop(..._: Array<unknown>): void;
+
 export function parsePascalCaseToSpineCase(x: string): string;
 
 export function parseSpineCaseToCamelCase(x: string): string;

library/utilities.js

@@ -44,6 +44,8 @@ export const maybeCall = (f, e, ...xs) => {
   return (p instanceof Promise ? p : Promise.resolve(p));
 };
 
+export const noop = (..._) => undefined;
+
 export const parseSelectorForElement = (e) => {
   const as = [e.localName];
   for (const { name, value } of e.attributes) {